Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-airlift] Flesh out airlift landing page #25815

Merged

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Nov 8, 2024

Summary & Motivation

Flesh out the Airlift landing page.

docs/content/integrations/airlift.mdx Outdated Show resolved Hide resolved
docs/content/integrations/airlift.mdx Outdated Show resolved Hide resolved
@dpeng817 dpeng817 marked this pull request as ready for review November 8, 2024 19:30
Copy link

github-actions bot commented Nov 8, 2024

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved w/ one small suggestion

docs/content/integrations/airlift.mdx Outdated Show resolved Hide resolved
docs/content/integrations/airlift.mdx Outdated Show resolved Hide resolved
docs/content/integrations/airlift.mdx Outdated Show resolved Hide resolved
@dpeng817 dpeng817 force-pushed the dpeng817/remove_sections_in_reference branch from 3794777 to f9b9860 Compare November 12, 2024 17:31
@dpeng817 dpeng817 force-pushed the dpeng817/airlift_landing_page branch from 73f30ca to b922417 Compare November 12, 2024 17:31

### REST API Availability

Airlift depends on the availability of Airflow’s REST API. Airflow’s REST API was made stable in its 2.0 release (Dec 2020) and was introduced experimentally in 1.10 in August 2018. Currently Airflow requires the availability of the REST API.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence "Currently Airflow requires the availability of the REST API" should be corrected to "Currently Airlift requires the availability of the Airflow REST API" to accurately reflect that this is a dependency of the Airlift package, not a requirement of Airflow itself.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants