[dagster-airlift][federation-tutorial] Implement dags #25885
Merged
+345
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
Merged
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| ) as dag: | ||
| PythonOperator( | ||
| task_id=f"task_{i}", | ||
| python_callable=lambda: None, |
There was a problem hiding this comment.
The lambda function captures the loop variable i, which can lead to unexpected behavior. All tasks will use the final value of i. To fix this, use a default argument to bind the current value: python_callable=lambda x=i: None
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
379d28d
to
ce20018
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
69b6cae
to
fc3bfd8
Compare
This was referenced Nov 13, 2024
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-la5umf9eh-elementl.vercel.app Direct link to changed pages: |
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/13/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
cmpadden
approved these changes
Nov 13, 2024
dpeng817
changed the title
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
ce20018
to
1b9ba9e
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
fc3bfd8
to
56dc056
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
1b9ba9e
to
fd09a10
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
56dc056
to
e4270a2
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
fd09a10
to
2d05d25
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
e4270a2
to
5e67354
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
2d05d25
to
e67e6ea
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
5e67354
to
2ac9632
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
e67e6ea
to
b29e016
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
2ac9632
to
13ff868
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
b29e016
to
53c17ac
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
13ff868
to
09b59d8
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
53c17ac
to
2a4cd92
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
09b59d8
to
ee91104
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
2a4cd92
to
1ca3d88
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
ee91104
to
64722c3
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
1ca3d88
to
dbbf541
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
64722c3
to
b896f9c
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
dbbf541
to
0be6ddb
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
b896f9c
to
1821ae4
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
0be6ddb
to
714e55f
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
1821ae4
to
cb5258e
Compare
dpeng817
force-pushed
the
dpeng817/fed-tutorial-overview-setup
branch
from
714e55f
to
4c45c85
Compare
dpeng817
force-pushed
the
dpeng817/implement_dags
branch
from
cb5258e
to
31e1b1e
Compare
Base automatically changed from
dpeng817/fed-tutorial-overview-setup
to
dpeng817/federation-tutorial
November 14, 2024 18:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog