[dagster-airlift] decomission section #25823
Merged
+144
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| ) | ||
|
|
||
|
|
||
| rebuild_customer_list_schedule = rebuild_customers_list_schedule = ScheduleDefinition( |
There was a problem hiding this comment.
There appears to be a duplicate variable assignment where the schedule is assigned to both rebuild_customer_list_schedule and rebuild_customers_list_schedule. Additionally, there's an inconsistency in naming - one uses "customer" (singular) while the other uses "customers" (plural). Consider standardizing on one name, perhaps rebuild_customers_list_schedule, and removing the duplicate assignment.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This was referenced Nov 8, 2024
This was referenced Nov 8, 2024
This was referenced Nov 12, 2024
cmpadden
approved these changes
Nov 12, 2024
dpeng817
force-pushed
the
dpeng817/migration
branch
from
2570820
to
bcb4130
Compare
dpeng817
force-pushed
the
dpeng817/decomission
branch
from
69ec87c
to
850d09b
Compare
docs/content/_navigation.json
Outdated
| @@ -935,6 +935,10 @@ | |||
| { | |||
| "title": "Part 4: Migrating assets", | |||
| "path": "/integrations/airlift/tutorial/migrate" | |||
| }, | |||
| { | |||
| "title": "Part 5: Decomissioning the Airflow DAG", | |||
There was a problem hiding this comment.
The word "Decomissioning" is misspelled. The correct spelling is "Decommissioning".
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/migration
branch
from
bcb4130
to
1d9e857
Compare
dpeng817
force-pushed
the
dpeng817/decomission
branch
from
850d09b
to
adbb351
Compare
Base automatically changed from
dpeng817/migration
to
dpeng817/remove_sections_in_reference
November 12, 2024 18:34
dpeng817
merged commit adbb351
into
dpeng817/remove_sections_in_reference
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Section on decomissioning the airflow dag + relevant links. very little change on this one.