Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-airlift][federation-tutorial] Add initial stage to add specs to federation tutorial #25861

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[dagster-airlift][federation-tutorial] Add initial stage to add specs to federation tutorial #25861

merged 1 commit into from
Nov 14, 2024
+132 −2

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Nov 12, 2024 •
edited
Loading

Summary & Motivation

Add an initial stage to the federation tutorial which instantiates an upstream and downstream dag asset, as well as a sensor for each instance.

How I Tested These Changes

New test that "acts out" a replacement of the code with the completed stage and ensures module loads correctly.

This was referenced Nov 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dpeng817 Graphite App
Copy link
Contributor Author

dpeng817 commented Nov 12, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dpeng817 dpeng817 mentioned this pull request Nov 12, 2024
Open
@dpeng817 dpeng817 marked this pull request as ready for review November 12, 2024 00:15
@dpeng817 dpeng817 mentioned this pull request Nov 12, 2024
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 13, 2024

Graphite Automations

"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/13/24)

1 label was added to this PR based on Christopher DeCarolis's automation.

@dpeng817 dpeng817 merged commit 9e1b2e6 into dpeng817/federation-tutorial Nov 14, 2024
1 check was pending
@dpeng817 dpeng817 deleted the dpeng817/add_initial_stage branch November 14, 2024 18:10
This was referenced Nov 14, 2024
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmpadden cmpadden cmpadden approved these changes

@benpankow benpankow Awaiting requested review from benpankow

@schrockn schrockn Awaiting requested review from schrockn

Assignees
No one assigned
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpeng817 @cmpadden