-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift][federation-apis] Standalone sensor def creation fxn #25862
Open
dpeng817
wants to merge
1
commit into
dpeng817/load_airflow_dag_asset_specs
Choose a base branch
from
dpeng817/standalone_sensor_def_fxn
base: dpeng817/load_airflow_dag_asset_specs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[dagster-airlift][federation-apis] Standalone sensor def creation fxn #25862
dpeng817
wants to merge
1
commit into
dpeng817/load_airflow_dag_asset_specs
from
dpeng817/standalone_sensor_def_fxn
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
Merged
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 12, 2024 17:33
995c0fc
to
ca393ac
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 12, 2024 17:34
330320a
to
b9649d9
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 18:59
292d67f
to
5f446bf
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 18:59
8613eae
to
ecd505a
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 19:09
5f446bf
to
23aea39
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 19:09
ecd505a
to
78b32c8
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 19:14
23aea39
to
60edc68
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 19:14
78b32c8
to
e23ec9c
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 19:58
60edc68
to
292239c
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 19:58
e23ec9c
to
ef3869a
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 20:00
292239c
to
8196ec1
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 20:00
ef3869a
to
a68a877
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
2 times, most recently
from
November 13, 2024 21:59
b990c7f
to
2291ada
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 21:59
a68a877
to
fd90c6c
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 22:02
2291ada
to
5706484
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 22:02
fd90c6c
to
f1ca203
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 22:17
5706484
to
f2f5180
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 22:18
f1ca203
to
7fb9149
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 23:18
f2f5180
to
744d696
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 23:18
7fb9149
to
e22695f
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 13, 2024 23:43
744d696
to
c279577
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 23:43
e22695f
to
52fe220
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
2 times, most recently
from
November 13, 2024 23:46
e1f9602
to
e9bf723
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 13, 2024 23:46
52fe220
to
b712824
Compare
benpankow
approved these changes
Nov 14, 2024
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
November 14, 2024 19:45
e9bf723
to
3117e08
Compare
dpeng817
force-pushed
the
dpeng817/standalone_sensor_def_fxn
branch
from
November 14, 2024 19:45
b712824
to
cc5370b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Previously our fxn was creating a Definitions object. Let's change to creating a SensorDefinition directly.