[dagster-airlift][federation-tutorial] Add executable stage to federation tutorial #25879
+132
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+86
to
+89
| defs = Definitions( | ||
| assets=[load_customers_dag_asset, run_customer_metrics], | ||
| sensors=[upstream_sensor, downstream_sensor], | ||
| ) |
There was a problem hiding this comment.
The automation_sensor is defined on line 77 but not included in the Definitions object. Please add it to the sensors list:
defs = Definitions(
assets=[load_customers_dag_asset, run_customer_metrics],
sensors=[upstream_sensor, downstream_sensor, automation_sensor],
)Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
32e86ba
to
90553f2
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
1752c19
to
966eda1
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
a67b171
to
564992c
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
966eda1
to
e0a8348
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
564992c
to
2cb0723
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
e0a8348
to
3a010f8
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
2cb0723
to
d8586ac
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
3a010f8
to
ee6693f
Compare
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/13/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
cmpadden
approved these changes
Nov 13, 2024
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
d8586ac
to
37bca1d
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
ee6693f
to
d83cb72
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
37bca1d
to
80a3f32
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
d83cb72
to
e65592c
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
80a3f32
to
1853cf8
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
e65592c
to
eb2ff6c
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
1853cf8
to
d2b91b7
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
eb2ff6c
to
f68c39c
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
2 times, most recently
from
4db8ff5
to
5d222bf
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
f68c39c
to
7c14bcd
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
5d222bf
to
4c9646d
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
7c14bcd
to
3996fd2
Compare
dpeng817
force-pushed
the
dpeng817/add_initial_stage
branch
from
4c9646d
to
9e1b2e6
Compare
dpeng817
force-pushed
the
dpeng817/executable_stage
branch
from
3996fd2
to
3ac09db
Compare
Base automatically changed from
dpeng817/add_initial_stage
to
dpeng817/federation-tutorial
November 14, 2024 18:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds an additional stage to the federation tutorial where we actually make the downstream asset executable and add an automation condition.