-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift][federation-tutorial] Use declarative automation #25893
[dagster-airlift][federation-tutorial] Use declarative automation #25893
Conversation
examples/airlift-federation-tutorial/snippets/federated_execution.py
Outdated
Show resolved
Hide resolved
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/13/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
ea3067a
to
2390f28
Compare
379cee6
to
4f797b1
Compare
2390f28
to
d038556
Compare
4f797b1
to
c14de07
Compare
d038556
to
3eb8689
Compare
c14de07
to
9b0fbe2
Compare
docs/content/integrations/airlift/federation-tutorial/federated-execution.mdx
Outdated
Show resolved
Hide resolved
raise Exception("Dag run failed.") | ||
``` | ||
|
||
We use the `AirflowInstance` defined earlier to trigger a run of the `customer_metrics` DAG. We then wait for the run to complete, and if it is successful, we'll succcessfully materialize the asset. If the run fails, we'll raise an exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more clear to preface the code with an explanation of what it does, and then follow-up with the code for them to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small points
3eb8689
to
9b8354a
Compare
9b0fbe2
to
ba3c1b7
Compare
9b8354a
to
2adfd07
Compare
ba3c1b7
to
8ebd3be
Compare
2adfd07
to
71aa819
Compare
6832e0c
to
1b7f00f
Compare
71aa819
to
72e4fe5
Compare
1b7f00f
to
a8fece7
Compare
a8fece7
to
6e2a831
Compare
72e4fe5
to
48e9247
Compare
6e2a831
to
798fcf9
Compare
48e9247
to
86ce701
Compare
798fcf9
to
6c33556
Compare
86ce701
to
3940172
Compare
6c33556
to
9fd24a1
Compare
3940172
to
7da4baa
Compare
9fd24a1
to
6a65363
Compare
Summary & Motivation
How I Tested These Changes
Changelog