[dagster-airlift][federation-apis] Load airflow dag asset specs #25858
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 12, 2024
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
e858107
to
995c0fc
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
8cb9eb6
to
8a83d7a
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
995c0fc
to
ca393ac
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
02a3249
to
09cf811
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
292239c
to
8196ec1
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
09cf811
to
f749ffe
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
8196ec1
to
b990c7f
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
f749ffe
to
3b23857
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
b990c7f
to
2291ada
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
3b23857
to
ca0b0d6
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
2291ada
to
5706484
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
ca0b0d6
to
0f431c5
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
5706484
to
f2f5180
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
0f431c5
to
6e8a029
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
f2f5180
to
744d696
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
6e8a029
to
252e061
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
744d696
to
c279577
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
2 times, most recently
from
66d03ae
to
790dad2
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
c279577
to
e1f9602
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
790dad2
to
46df90c
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
e1f9602
to
e9bf723
Compare
benpankow
reviewed
Nov 14, 2024
examples/experimental/dagster-airlift/dagster_airlift/core/load_defs.py
Outdated
Show resolved
Hide resolved
benpankow
approved these changes
Nov 14, 2024
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
46df90c
to
e9d165b
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
e9bf723
to
3117e08
Compare
dpeng817
force-pushed
the
dpeng817/enrich_mapped_assets
branch
from
e9d165b
to
5e8ff6d
Compare
dpeng817
force-pushed
the
dpeng817/load_airflow_dag_asset_specs
branch
from
3117e08
to
939edad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A method to load asset specs for a given airflow dag. This better conforms to the BI/dbt integration format that we've previously established, and will form the basis of our federation APIs.
How I Tested These Changes
new unit tests for basic fxnality.