-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set of fixes and improvements for vega-market-sim #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80ea56d
to
61e4a58
Compare
2f72d4c
to
1de5fa9
Compare
daniel1302
commented
Jul 29, 2023
61eab43
to
ca5be5d
Compare
07b71fd
to
fe42db9
Compare
TomMcL
reviewed
Jul 31, 2023
TomMcL
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to reverse engineer how this is fixing datanode still, but I'll take a working node!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
I really need this pipeline to test my nullchain changes in the core.
Changes
tools.retry
function that retries the given code and returns the result or throws an exception when all of the attempts fail.PARALLEL_WORKERS
,TEST_FUNCTION
, andLOG_LEVEL
- They allow driving the integration tests script. Jenkins now has support for it - see the related PR.pytest-dist
library that has been already included in thepoetry.lock
. I have tested those PRs against that run as wellconftest.py
, and some params in thepytest.ini
. Those settings enable writing test logs into the file. Now files are saved in the `Jenkins artifacts (you can confirm it here: https://jenkins.ops.vega.xyz/job/common/job/vega-market-sim/2607/artifact/test_logs/ ) - one file per worker.test_rl_run
test for the integration run. It takes a very long time to run this single scenario. There is a following issue here(Re-enable thetest_rl_run
scenario #472) to run it0.0001s
and send up to 1000 requests per second. New sleep is 0.05 and time increases exponentially. Moreover, I have also decreased the number of tries - see details below.0.05 * 1.1**i
Sleep Changes
[0.0005 * 1.01**attempt for attempt in range(625)]
[0.05 * 1.03**attempt for attempt in range(100)]
Max wait:
sum([0.05 * 1.03**i for i in range(100)]) == 30.364386634760475
- 30.4 sec.sum([0.0005 * 1.01**i for i in range(625)]) == 25.05895385147325
- 25.1 secThe difference is that instead of
625
we send max100
requests.0.0005
seconds it was sending about 250 requests, (sum([0.0005 * 1.01**i for i in range(260)]) - 0.6145492739027707
) sometimes more - this is my observationBecause we were sending thousands of requests without reason we saw a lot of RPC Connection issues.
Testing
Breaking Changes
No breaking changes.
Closes
close vegaprotocol/devops-infra#1531 .
Related PRs: