feat: fix the retain_log_files

vegaprotocol · Jul 29, 2023 · 61e4a58 · 61e4a58
1 parent 7f453c5
commit 61e4a58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tests/integration/test_reinforcement.py b/tests/integration/test_reinforcement.py
@@ -2,6 +2,7 @@
 
 
 @pytest.mark.integration
+@pytest.mark.skip(reason="We will enable it once job is stable in the Jenkins")
 def test_rl_run():
     # Simply testing that it doesn't error
     import vega_sim.reinforcement.run_rl_agent as rl

diff --git a/vega_sim/null_service.py b/vega_sim/null_service.py
@@ -649,10 +649,10 @@ def sighandler(signal, frame):
             if process.poll() == -9:
                 logger.debug(f"Process {name} killed.")
 
-        if not retain_log_files:
+        if not retain_log_files and os.path.exists(tmp_vega_dir):
             shutil.rmtree(tmp_vega_dir)
 
-    # The below lines are workaround to put the listeners on top of the stack, so this process can handle it.
+    # The below lines are workaround to put the signal listeners on top of the stack, so this process can handle it.
     signal.signal(signal.SIGINT, lambda _s, _h: None)
     signal.signal(signal.SIGTERM, lambda _s, _h: None)
     signal.signal(signal.SIGCHLD, sighandler) # The process had previously created one or more child processes with the fork() function. One or more of these processes has since died.