feat: nullchain changes for snapshot-compatibility pipeline #8887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinTrinque
suggested changes
Jul 24, 2023
ValentinTrinque
suggested changes
Jul 24, 2023
daniel1302
force-pushed
the
null-chain-tunning
branch
2 times, most recently
from
ef7eef9 to
520c6de
Compare
daniel1302
changed the title
AnExsomnis
reviewed
Jul 26, 2023
daniel1302
force-pushed
the
null-chain-tunning
branch
3 times, most recently
from
58720c4 to
a9ff537
Compare
daniel1302
commented
Jul 28, 2023
daniel1302
force-pushed
the
null-chain-tunning
branch
2 times, most recently
from
ab4bc94 to
3d54d13
Compare
daniel1302
force-pushed
the
null-chain-tunning
branch
2 times, most recently
from
6e0cd7e to
2d5bb9e
Compare
wwestgarth
reviewed
Jul 31, 2023
| } | ||
|
|
||
| var err error | ||
| n.ethClient, err = ethclient.Dial(n.ctx, n.conf.Ethereum) |
There was a problem hiding this comment.
Not blocking, but worth noting:
Before if a node set up as a validator, and forgot to populate n.conf.Ethereum.RPCEndpoint it would fail when it tried to dial and the error would be useful, but now I think we'll probably just randomly panic with a nil-pointer the first time the ethClient tries to be used.
There was a problem hiding this comment.
We will not Dial when the n.conf.Ethereum.RPCEndpoint is empty.
wwestgarth
approved these changes
Jul 31, 2023
daniel1302
force-pushed
the
null-chain-tunning
branch
from
2d5bb9e to
1df38fd
Compare
ValentinTrinque
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close vegaprotocol/devops-infra#1531 .
Changes
Vega code disables some functionalities when we use null chain it causes an inability to use genesis where We have the ERC20 tokens - this means We cannot use the mainnet genesis. A very similar situation was with some of the snapshot items. Vega loads snapshots differently when We want to use the null chain.
I have removed branches for the null chain and now the null chain should behave in the same way as tendermint.
Triggered runs:
Related PRs