Use AntlrAssetSelectionParser in AssetSelection.from_string #25916
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
briantu
force-pushed
the
briantu/update-antlr-from-string
branch
2 times, most recently
from
5dd331f
to
49766f5
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5dd331f. |
briantu
force-pushed
the
briantu/update-antlr-from-string
branch
2 times, most recently
from
0615b89
to
e857b20
Compare
salazarm
reviewed
Nov 14, 2024
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
|
Can you add more tests to the test file. I did a quick look at them and I only saw 1 test case for the |
briantu
force-pushed
the
briantu/update-antlr-from-string
branch
from
054f3ad
to
cd6f320
Compare
salazarm
reviewed
Nov 14, 2024
| assert AssetSelection.from_string("+my_asset+") == AssetSelection.assets("my_asset").downstream( | ||
| depth=1, include_self=True | ||
| ) | AssetSelection.assets("my_asset").upstream(depth=1, include_self=True) | ||
| assert AssetSelection.from_string("*my_asset*") == AssetSelection.assets("my_asset").downstream( |
There was a problem hiding this comment.
can you also test `"my_asset some_other_asset*"
briantu
force-pushed
the
briantu/implement-visitor
branch
from
197977a
to
fe35c76
Compare
briantu
force-pushed
the
briantu/update-antlr-from-string
branch
from
cd6f320
to
18239ce
Compare
salazarm
approved these changes
Nov 14, 2024
briantu
changed the base branch from
briantu/implement-visitor
to
graphite-base/25916
briantu
force-pushed
the
briantu/update-antlr-from-string
branch
from
18239ce
to
41737dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We want to use the new
AntlrAssetSelectionParserin our backend to parse the new asset selection syntax into anAssetSelection. This should go in a try/catch inside theAssetSelection.from_stringmethod for backwards compatibility.How I Tested These Changes
Existing tests should pass