Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FOU-470] ANTLR Dev Setup #25759

Merged
merged 10 commits into from
Nov 14, 2024
Merged

[FOU-470] ANTLR Dev Setup #25759

merged 10 commits into from
Nov 14, 2024

Conversation

briantu
Copy link
Contributor

@briantu briantu commented Nov 6, 2024 •
edited
Loading

Summary & Motivation

Now that we have the files generated by ANTLR. We want to use those files to construct an AntlrAssetSelection class to actually use ANTLR for asset selection.

How I Tested These Changes

pytest python_modules/dagster/dagster_tests/asset_defs_tests/test_antlr_asset_selection.py

@briantu Graphite App
Copy link
Contributor Author

briantu commented Nov 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 6, 2024
Merged
Merged
@briantu briantu changed the title Setup AntlrAssetSelection [FOU-470] ANTLR dev setup Nov 6, 2024
@briantu briantu changed the title [FOU-470] ANTLR dev setup [FOU-470] ANTLR Dev Setup Nov 6, 2024
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 1a559e3 to 6635c3e Compare November 6, 2024 01:07
@briantu briantu requested a review from salazarm November 6, 2024 01:12
@briantu briantu marked this pull request as ready for review November 6, 2024 01:12
salazarm
salazarm approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from 056580d to 8dc1013 Compare November 6, 2024 22:51
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 686b440 to 59ac4b6 Compare November 6, 2024 22:51
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from 66b36f5 to fdb0ac3 Compare November 7, 2024 22:01
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 59ac4b6 to dc22bf7 Compare November 7, 2024 22:01
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from fdb0ac3 to 31ba29c Compare November 7, 2024 22:02
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from dc22bf7 to e18a086 Compare November 7, 2024 22:06
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from 31ba29c to 6a6a84d Compare November 7, 2024 22:40
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from f76d940 to 66d53aa Compare November 7, 2024 22:40
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from a207a62 to d447bdb Compare November 8, 2024 22:59
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 66d53aa to 5f0aacd Compare November 8, 2024 22:59
@briantu briantu mentioned this pull request Nov 8, 2024
Merged
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from d447bdb to fedd8a7 Compare November 8, 2024 23:00
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 5f0aacd to 4a0c4e9 Compare November 8, 2024 23:00
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from fedd8a7 to 0789d24 Compare November 8, 2024 23:04
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch 2 times, most recently from 5a82bfe to 0fb1592 Compare November 11, 2024 20:12
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 0fb1592 to 04c3c26 Compare November 11, 2024 21:01
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from 0789d24 to 0659c9e Compare November 11, 2024 21:16
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 04c3c26 to 2a32ffc Compare November 11, 2024 21:17
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from 0659c9e to 4e91627 Compare November 12, 2024 16:38
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 2a32ffc to ecb181b Compare November 12, 2024 16:38
@briantu briantu mentioned this pull request Nov 14, 2024
Merged
@briantu briantu force-pushed the briantu/new-asset-selection-syntax branch from 4e91627 to 2bf97d5 Compare November 14, 2024 20:32
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from ecb181b to 857ad28 Compare November 14, 2024 20:32
@briantu Graphite App
Copy link
Contributor Author

briantu commented Nov 14, 2024 •
edited
Loading

Merge activity

  • Nov 14, 3:50 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 4:00 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 14, 4:01 PM EST: A user merged this pull request with Graphite.

@briantu briantu changed the base branch from briantu/new-asset-selection-syntax to graphite-base/25759 November 14, 2024 20:55
@briantu briantu changed the base branch from graphite-base/25759 to master November 14, 2024 20:58
@briantu briantu force-pushed the briantu/set-up-antlr-asset-selection branch from 857ad28 to 4861842 Compare November 14, 2024 20:59
@briantu briantu merged commit a510e68 into master Nov 14, 2024
1 check was pending
@briantu briantu deleted the briantu/set-up-antlr-asset-selection branch November 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@OwenKephart OwenKephart OwenKephart left review comments

@salazarm salazarm salazarm approved these changes

@benpankow benpankow Awaiting requested review from benpankow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briantu @salazarm @OwenKephart