[FOU-470] ANTLR Code Generation #25654
Merged
+4,090
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
8e353fb
to
b53fbf8
Compare
benpankow
reviewed
Nov 5, 2024
python_modules/dagster/dagster/_core/definitions/antlr_asset_selection/antlr_asset_selection.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/antlr_asset_selection/AssetSelection.g4
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/antlr_asset_selection/fix_imports.py
Outdated
Show resolved
Hide resolved
...odules/dagster/dagster/_core/definitions/antlr_asset_selection/test_antlr_asset_selection.py
Outdated
Show resolved
Hide resolved
|
Can you use |
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
2 times, most recently
from
877b79d
to
9d4443c
Compare
briantu
changed the title
briantu
changed the title
briantu
changed the title
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
4117572
to
cec3d08
Compare
benpankow
reviewed
Nov 6, 2024
python_modules/dagster/dagster/_core/definitions/antlr_asset_selection/README.md
Show resolved
Hide resolved
salazarm
reviewed
Nov 6, 2024
python_modules/dagster/dagster/_core/definitions/antlr_asset_selection/README.md
Outdated
Show resolved
Hide resolved
benpankow
approved these changes
Nov 6, 2024
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
4 times, most recently
from
31ba29c
to
6a6a84d
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
a207a62
to
d447bdb
Compare
briantu
changed the base branch from
master
to
briantu/subset-asset-selection
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
cbda902
to
f1af892
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
fedd8a7
to
0789d24
Compare
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
f1af892
to
79d6163
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
0789d24
to
0659c9e
Compare
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
79d6163
to
813f92b
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
0659c9e
to
4e91627
Compare
salazarm
added a commit
that referenced
this pull request
Nov 14, 2024
## Summary & Motivation Similar to #25654. Generates the lexer/parser/base visitor interface that we'll using to parse and evaluate the new asset selection syntax. ## How I Tested These Changes These are generate files, no tests needed.
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
813f92b
to
143fb12
Compare
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
4e91627
to
2bf97d5
Compare
briantu
changed the base branch from
briantu/subset-asset-selection
to
graphite-base/25654
briantu
force-pushed
the
briantu/new-asset-selection-syntax
branch
from
2bf97d5
to
4072796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We want to use ANTLR to define a new grammar for asset selection. This PR includes the files generated by ANTLR and a
README.mdon how to generate them.How I Tested These Changes
Changelog