Implement KeySubstringAssetSelection #25800
Merged
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Will add tests. Just wondering if I'm on the right track here. Some questions:
|
benpankow
requested changes
Nov 8, 2024
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/asset_selection.py
Outdated
Show resolved
Hide resolved
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
21233a0
to
321a6ab
Compare
This was referenced Nov 8, 2024
briantu
force-pushed
the
briantu/subset-asset-selection
branch
2 times, most recently
from
cbda902
to
f1af892
Compare
benpankow
approved these changes
Nov 11, 2024
briantu
changed the title
briantu
force-pushed
the
briantu/subset-asset-selection
branch
2 times, most recently
from
79d6163
to
813f92b
Compare
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
813f92b
to
143fb12
Compare
briantu
force-pushed
the
briantu/subset-asset-selection
branch
from
143fb12
to
0c00cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We want to support subset matching asset keys in the new asset selection syntax. Thus, we need to define a new
KeySubstringAssetSelectionclass to support subset matching asset keys given a list of strings.How I Tested These Changes