Use AssetSelection.key_substring

dagster-io · Nov 14, 2024 · fe35c76 · fe35c76
1 parent da5f8cb
commit fe35c76
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/..._modules/dagster/dagster/_core/definitions/antlr_asset_selection/antlr_asset_selection.py b/..._modules/dagster/dagster/_core/definitions/antlr_asset_selection/antlr_asset_selection.py
@@ -93,9 +93,9 @@ def visitKeyExpr(self, ctx: AssetSelectionParser.KeyExprContext):
         value = self.visit(ctx.value())
         return AssetSelection.assets(value)
 
-    def visitKeySubsetExpr(self, ctx: AssetSelectionParser.KeySubsetExprContext):
+    def visitKeySubstringExpr(self, ctx: AssetSelectionParser.KeySubstringExprContext):
         value = self.visit(ctx.value())
-        return AssetSelection.key_prefixes(value)
+        return AssetSelection.key_substring(value)
 
     def visitTagAttributeExpr(self, ctx: AssetSelectionParser.TagAttributeExprContext):
         key = self.visit(ctx.value(0))

diff --git a/python_modules/dagster/dagster_tests/asset_defs_tests/test_antlr_asset_selection.py b/python_modules/dagster/dagster_tests/asset_defs_tests/test_antlr_asset_selection.py
@@ -93,6 +93,9 @@ def test_antlr_tree_invalid(selection_str):
     "selection_str, expected_assets",
     [
         ("key:a", AssetSelection.assets("a")),
+        ('key:"*/a+"', AssetSelection.assets("*/a+")),
+        ("key_substring:a", AssetSelection.key_substring("a")),
+        ('key_substring:"*/a+"', AssetSelection.key_substring("*/a+")),
         ("not key:a", AssetSelection.all(include_sources=True) - AssetSelection.assets("a")),
         ("key:a and key:b", AssetSelection.assets("a") & AssetSelection.assets("b")),
         ("key:a or key:b", AssetSelection.assets("a") | AssetSelection.assets("b")),