Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/bass/ground.go: add quotes around godoc arguments #252

Closed
wants to merge 1 commit into from

Conversation

srenatus
Copy link
Contributor

Fixes #251.

ℹ️ I've not tried to check that this works locally. Or rather, I've tried the actual call in the REPL, but I haven't tried building the docs.

@srenatus
Copy link
Contributor Author

I'll look into running the correct steps to get this green. Just been lazy so far here...

@vito
Copy link
Owner

vito commented Sep 17, 2022

No worries, I've been a bit under the weather lately (nothing serious) so I've gotten lazy myself with PRs. 😆

There's no easy re-triggering at the moment with Bass Loop (besides rebase+push) so I can just merge this as-is; it seems obviously fine.

I'll leave it around for a bit in case you're still troubleshooting #196 but let me know and I'll just merge it in.

@srenatus
Copy link
Contributor Author

Tried force-pushing while the runner was running -- I haven't noticed anything on its local logs, but loop seems to have found it to be successful: https://loop.bass-lang.org/runs/39c06b5f-9fd1-401b-a599-7e18bc60c616. However, it's still Waiting for status here 🤔

@srenatus
Copy link
Contributor Author

Hmm looking at the other PR in the bass loop logs, there's checks that succeeded; I don't find any of those for my runs... 🔍

@srenatus
Copy link
Contributor Author

I'll open another one, just for trying the obvious... Sorry for the noise 🙃

@srenatus
Copy link
Contributor Author

🙈 Now the two PRs with the same commit have their status reported in both places, or something...? It looks like #255 is more promising, but it also changed the status here, which is unexpected.

@srenatus
Copy link
Contributor Author

The other PR got picked up by the runner. I'll close this one.

@srenatus srenatus closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs have surprising call traces in outputs
2 participants