bass --runner with protected ssh key fails (ssh-agent support?)

[srenatus]

When I run bass --runner [email protected], I get this:

1: [8.91s] 10:27:59.557	error	failed to parse key	{"error": "ssh: this private key is passphrase protected", "key": "id_ed25519"}
1: [8.91s] 10:27:59.557	info	serving runtimes	{"host": "github.bass-lang.org", "port": "6455", "user": "srenatus"}
1: [9.26s] 10:27:59.904	error	failed to dial	{"error": "ssh: handshake failed: knownhosts: key is unknown"}

The error is accurate, the ssh key I use with github is password-protected. However, it's unlocked with the ssh-agent:

$ ssh [email protected]                                
PTY allocation request failed on channel 0
Hi srenatus! You've successfully authenticated, but GitHub does not provide shell access.
Connection to github.com closed.

[vito]

bass --runner actually tries to use the agent if you have $SSH_AUTH_SOCK set, but it looks like it didn't use it in this case. Is that env set?

bass/cmd/bass/runner.go

Line 82 in e82a988

socket, hasAgent := os.LookupEnv("SSH_AUTH_SOCK")

You'll also need to add the remote SSH host key to ~/.ssh/known_hosts (sorry, I don't think this is documented atm) to avoid the error in the last line there:

ssh-keyscan -p 6455 github.bass-lang.org >> ~/.ssh/known_hosts

Hope this helps!

[srenatus]

Sorry I've dropped the ball here -- just now tried to run this again. 😅

$ echo $SSH_AUTH_SOCK
/private/tmp/com.apple.launchd.azCoQjXH1l/Listeners

I now get an error still, but it seems to be doing something afterwards:

vito/bass % bass --runner [email protected]
20:31:12.541	error	failed to parse key	{"error": "ssh: this private key is passphrase protected", "key": "id_ed25519"}
=> [ssh] forward --os linux --arch amd64 [214.3s]
 ▕ 18:31:14.413    info    registered  {"side": "server"}                                                                                                                                                                                                                                                                            
 ▕ 18:32:14.415    debug   heartbeated {"side": "server"}                                                                                                                                                                                                                                                                            
 ▕ 18:33:14.415    debug   heartbeated {"side": "server"}                                                                                                                                                                                                                                                                            
 ▕ 18:34:14.414    debug   heartbeated {"side": "server"}                                                                                                                                                                                                                                                                            
=> bass --runner [email protected] [214.6s]
 ▕ 20:31:13.901    info    serving runtime {"platform": "os=linux, arch=any", "hosts": ["github.bass-lang.org:6455"], "user": "srenatus"}     

That said, a previously opened PR (#252) didn't seem to be run there 🤔 I might be misunderstanding something still, though.

[vito]

Looks like it's working, that error log is probably just noise; it'll try each key, and judging by the heartbeats it eventually tried the agent which worked.

Here's the run that ties to #252: https://loop.bass-lang.org/runs/4fcc96b4-d550-47fb-af1f-09d882b8e4a5 - it looks like it wasn't able to find any runtimes.

Maybe the PR was opened before the runner was up? 🤔

[srenatus]

Maybe the PR was opened before the runner was up? 🤔

Yes indeed. What can I do now? Close and re-open or open a new one?

[vito]

Yeah, it failed at an early phase before checks could even be created so there's nothing to re-run unfortunately. Still need to fix that flow.

One thing you can do is just amend (maybe tweak the commit message) and force-push.