chore(react-components): split react libraries in two (/library and /stories) - teams-prg /1st batch #31586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
fabricteam
reviewed
Jun 5, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 32 | 35 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 643 | 620 | 5000 | |
| Button | mount | 303 | 292 | 5000 | |
| Field | mount | 1109 | 1102 | 5000 | |
| FluentProvider | mount | 717 | 737 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 32 | 35 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 76 | 10 | |
| MakeStyles | mount | 877 | 866 | 50000 | |
| Persona | mount | 1800 | 1739 | 5000 | |
| SpinButton | mount | 1405 | 1373 | 5000 | |
| SwatchPicker | mount | 1523 | 1536 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 87 | 82 | 1.06:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 89 | 80 | 1.11:1 |
| RefMinimalPerf.default | 113 | 102 | 1.11:1 |
| SkeletonMinimalPerf.default | 209 | 188 | 1.11:1 |
| LayoutMinimalPerf.default | 201 | 186 | 1.08:1 |
| LabelMinimalPerf.default | 238 | 222 | 1.07:1 |
| LoaderMinimalPerf.default | 201 | 188 | 1.07:1 |
| DropdownManyItemsPerf.default | 414 | 392 | 1.06:1 |
| GridMinimalPerf.default | 204 | 192 | 1.06:1 |
| PortalMinimalPerf.default | 85 | 80 | 1.06:1 |
| ProviderMinimalPerf.default | 214 | 201 | 1.06:1 |
| CardMinimalPerf.default | 314 | 300 | 1.05:1 |
| HeaderMinimalPerf.default | 212 | 201 | 1.05:1 |
| AttachmentSlotsPerf.default | 652 | 627 | 1.04:1 |
| DialogMinimalPerf.default | 446 | 430 | 1.04:1 |
| SegmentMinimalPerf.default | 204 | 196 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 154 | 149 | 1.03:1 |
| EmbedMinimalPerf.default | 1922 | 1864 | 1.03:1 |
| ListCommonPerf.default | 397 | 387 | 1.03:1 |
| ListWith60ListItems.default | 368 | 358 | 1.03:1 |
| AnimationMinimalPerf.default | 301 | 294 | 1.02:1 |
| ButtonSlotsPerf.default | 325 | 318 | 1.02:1 |
| CarouselMinimalPerf.default | 260 | 254 | 1.02:1 |
| DatepickerMinimalPerf.default | 3790 | 3708 | 1.02:1 |
| InputMinimalPerf.default | 558 | 545 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 716 | 702 | 1.02:1 |
| RosterPerf.default | 1592 | 1568 | 1.02:1 |
| PopupMinimalPerf.default | 359 | 353 | 1.02:1 |
| RadioGroupMinimalPerf.default | 271 | 265 | 1.02:1 |
| ReactionMinimalPerf.default | 213 | 208 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2308 | 2271 | 1.02:1 |
| StatusMinimalPerf.default | 401 | 395 | 1.02:1 |
| IconMinimalPerf.default | 385 | 377 | 1.02:1 |
| TableManyItemsPerf.default | 1124 | 1099 | 1.02:1 |
| ToolbarMinimalPerf.default | 552 | 542 | 1.02:1 |
| TooltipMinimalPerf.default | 1269 | 1244 | 1.02:1 |
| TreeMinimalPerf.default | 490 | 479 | 1.02:1 |
| TreeWith60ListItems.default | 90 | 88 | 1.02:1 |
| BoxMinimalPerf.default | 197 | 195 | 1.01:1 |
| ChatMinimalPerf.default | 448 | 442 | 1.01:1 |
| CheckboxMinimalPerf.default | 1143 | 1131 | 1.01:1 |
| DropdownMinimalPerf.default | 1426 | 1411 | 1.01:1 |
| FormMinimalPerf.default | 223 | 221 | 1.01:1 |
| MenuMinimalPerf.default | 510 | 506 | 1.01:1 |
| MenuButtonMinimalPerf.default | 970 | 960 | 1.01:1 |
| TextMinimalPerf.default | 197 | 195 | 1.01:1 |
| CustomToolbarPrototype.default | 1483 | 1465 | 1.01:1 |
| VideoMinimalPerf.default | 457 | 452 | 1.01:1 |
| ButtonOverridesMissPerf.default | 664 | 665 | 1:1 |
| ChatWithPopoverPerf.default | 209 | 208 | 1:1 |
| DividerMinimalPerf.default | 204 | 204 | 1:1 |
| SliderMinimalPerf.default | 742 | 740 | 1:1 |
| ButtonMinimalPerf.default | 87 | 88 | 0.99:1 |
| HeaderSlotsPerf.default | 459 | 463 | 0.99:1 |
| ProviderMergeThemesPerf.default | 656 | 660 | 0.99:1 |
| TableMinimalPerf.default | 230 | 232 | 0.99:1 |
| ImageMinimalPerf.default | 221 | 225 | 0.98:1 |
| ListNestedPerf.default | 322 | 328 | 0.98:1 |
| AlertMinimalPerf.default | 152 | 157 | 0.97:1 |
| FlexMinimalPerf.default | 149 | 153 | 0.97:1 |
| ListMinimalPerf.default | 305 | 320 | 0.95:1 |
| TextAreaMinimalPerf.default | 269 | 288 | 0.93:1 |
| AvatarMinimalPerf.default | 104 | 126 | 0.83:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 619 | 634 | 5000 | |
| Breadcrumb | mount | 1712 | 1702 | 1000 | |
| Checkbox | mount | 1698 | 1722 | 5000 | |
| CheckboxBase | mount | 1498 | 1495 | 5000 | |
| ChoiceGroup | mount | 2960 | 3001 | 5000 | |
| ComboBox | mount | 681 | 692 | 1000 | |
| CommandBar | mount | 6570 | 6538 | 1000 | |
| ContextualMenu | mount | 12500 | 12439 | 1000 | |
| DefaultButton | mount | 789 | 788 | 5000 | |
| DetailsRow | mount | 2210 | 2253 | 5000 | |
| DetailsRowFast | mount | 2238 | 2243 | 5000 | |
| DetailsRowNoStyles | mount | 2039 | 2063 | 5000 | |
| Dialog | mount | 2659 | 2817 | 1000 | |
| DocumentCardTitle | mount | 228 | 232 | 1000 | |
| Dropdown | mount | 2019 | 1991 | 5000 | |
| FocusTrapZone | mount | 1147 | 1170 | 5000 | |
| FocusZone | mount | 1097 | 1093 | 5000 | |
| GroupedList | mount | 42132 | 42205 | 2 | |
| GroupedList | virtual-rerender | 18145 | 20278 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51038 | 51000 | 2 | |
| GroupedListV2 | mount | 233 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 213 | 203 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 223 | 2 | |
| IconButton | mount | 1139 | 1137 | 5000 | |
| Label | mount | 357 | 342 | 5000 | |
| Layer | mount | 2719 | 2743 | 5000 | |
| Link | mount | 396 | 401 | 5000 | |
| MenuButton | mount | 986 | 996 | 5000 | |
| MessageBar | mount | 21419 | 21499 | 5000 | |
| Nav | mount | 2096 | 2024 | 1000 | |
| OverflowSet | mount | 783 | 799 | 5000 | |
| Panel | mount | 1824 | 1810 | 1000 | |
| Persona | mount | 744 | 727 | 1000 | |
| Pivot | mount | 903 | 905 | 1000 | |
| PrimaryButton | mount | 938 | 942 | 5000 | |
| Rating | mount | 4670 | 4745 | 5000 | |
| SearchBox | mount | 908 | 945 | 5000 | |
| Shimmer | mount | 1887 | 1881 | 5000 | |
| Slider | mount | 1338 | 1328 | 5000 | |
| SpinButton | mount | 3047 | 2939 | 5000 | |
| Spinner | mount | 407 | 381 | 5000 | |
| SplitButton | mount | 1918 | 1869 | 5000 | |
| Stack | mount | 396 | 410 | 5000 | |
| StackWithIntrinsicChildren | mount | 867 | 858 | 5000 | |
| StackWithTextChildren | mount | 2655 | 2652 | 5000 | |
| SwatchColorPicker | mount | 6401 | 6434 | 5000 | |
| TagPicker | mount | 1448 | 1457 | 5000 | |
| Text | mount | 384 | 379 | 5000 | |
| TextField | mount | 958 | 959 | 5000 | |
| ThemeProvider | mount | 848 | 857 | 5000 | |
| ThemeProvider | virtual-rerender | 597 | 567 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1296 | 1313 | 5000 | |
| Toggle | mount | 642 | 634 | 5000 | |
| buttonNative | mount | 197 | 195 | 5000 |
fabricteam
reviewed
Jun 5, 2024
Hotell
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
17 tasks
Hotell
force-pushed
the
type-checking-perf/apply/teams-1
branch
from
aee133f to
65004b9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Hotell
force-pushed
the
type-checking-perf/apply/teams-1
branch
from
65004b9 to
dc87967
Compare
fabricteam
reviewed
Jun 6, 2024
Closed
2 tasks
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…stories) - teams-prg /1st batch (microsoft#31586)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Note
Based on RFC v9 react packages are split in two: #30514
Package/Scaffold changes:
yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>Related Issue(s)