You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After migration to library/ and stories/ split package structure is merged and there are existing PR's or PRs created from out-dated upstream/master proper CODEOWNERS will not be assigned to PR.
Expected Behavior
CODEOWNERS should work for out of date branches for some time ( let's say till July 1st )
Solution
Keep package parent folder for codeowners when migrating packages.
After July 1st these extra paths will be removed from codeowners in order to adhere to Codewner per package pattern.
Library
React Components / v9 (@fluentui/react-components)
System Info
Are you reporting Accessibility issue?
None
Reproduction
Bug Description
Actual Behavior
After migration to
library/
andstories/
split package structure is merged and there are existing PR's or PRs created from out-datedupstream/master
proper CODEOWNERS will not be assigned to PR.Expected Behavior
CODEOWNERS should work for out of date branches for some time ( let's say till July 1st )
Solution
Keep package parent folder for codeowners when migrating packages.
After July 1st these extra paths will be removed from codeowners in order to adhere to Codewner per package pattern.
Fix:
+ packages/react-components/react-toolbar @microsoft/teams-prg @chpalac @ling1726 packages/react-components/react-toolbar/library @microsoft/teams-prg @chpalac @ling1726 packages/react-components/react-toolbar/stories @microsoft/teams-prg @chpalac @ling1726
↓↓ after July 1st ↓↓
- packages/react-components/react-toolbar @microsoft/teams-prg @chpalac @ling1726 packages/react-components/react-toolbar/library @microsoft/teams-prg @chpalac @ling1726 packages/react-components/react-toolbar/stories @microsoft/teams-prg @chpalac @ling1726
Logs
No response
Requested priority
Normal
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
The text was updated successfully, but these errors were encountered: