Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove codesandbox ci #31599

Merged
merged 1 commit into from
Jun 6, 2024
Merged

ci: remove codesandbox ci #31599

merged 1 commit into from
Jun 6, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 6, 2024

Previous Behavior

New Behavior

Recently codesandbox pipelines started failing on every PR

Example:

#31586
image

Why?

I dunno 🕵️‍♂️ but it is clearly broken on their side as those pipeline Pass but show as failed within our PRs

image

Action:

  • CS app was removed from repo
  • this PR removes ci config

Related Issue(s)

@Hotell Hotell marked this pull request as ready for review June 6, 2024 12:43
@Hotell Hotell requested a review from a team as a code owner June 6, 2024 12:43
@Hotell Hotell enabled auto-merge (squash) June 6, 2024 12:43
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 36 38 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 651 639 5000
Button mount 300 308 5000
Field mount 1165 1160 5000
FluentProvider mount 712 707 5000
FluentProviderWithTheme mount 81 85 10
FluentProviderWithTheme virtual-rerender 36 38 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 75 79 10
MakeStyles mount 869 868 50000
Persona mount 1810 1760 5000
SpinButton mount 1391 1406 5000
SwatchPicker mount 1553 1579 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LoaderMinimalPerf.default 203 174 1.17:1
AvatarMinimalPerf.default 120 105 1.14:1
ChatDuplicateMessagesPerf.default 171 153 1.12:1
TreeWith60ListItems.default 89 81 1.1:1
ButtonSlotsPerf.default 321 294 1.09:1
ReactionMinimalPerf.default 225 206 1.09:1
GridMinimalPerf.default 198 183 1.08:1
RadioGroupMinimalPerf.default 264 247 1.07:1
RefMinimalPerf.default 114 107 1.07:1
HeaderSlotsPerf.default 478 453 1.06:1
InputMinimalPerf.default 531 502 1.06:1
LabelMinimalPerf.default 230 217 1.06:1
PopupMinimalPerf.default 363 344 1.06:1
DividerMinimalPerf.default 203 194 1.05:1
PortalMinimalPerf.default 85 81 1.05:1
TooltipMinimalPerf.default 1259 1194 1.05:1
TreeMinimalPerf.default 494 472 1.05:1
AlertMinimalPerf.default 163 156 1.04:1
AnimationMinimalPerf.default 300 289 1.04:1
CarouselMinimalPerf.default 262 251 1.04:1
DatepickerMinimalPerf.default 3704 3555 1.04:1
DropdownManyItemsPerf.default 395 380 1.04:1
FormMinimalPerf.default 222 213 1.04:1
LayoutMinimalPerf.default 203 196 1.04:1
SliderMinimalPerf.default 737 709 1.04:1
SplitButtonMinimalPerf.default 2306 2215 1.04:1
IconMinimalPerf.default 415 398 1.04:1
TableMinimalPerf.default 242 233 1.04:1
AttachmentSlotsPerf.default 660 641 1.03:1
ListCommonPerf.default 387 377 1.03:1
MenuMinimalPerf.default 507 492 1.03:1
TextAreaMinimalPerf.default 301 293 1.03:1
CustomToolbarPrototype.default 1499 1455 1.03:1
ToolbarMinimalPerf.default 553 535 1.03:1
ButtonMinimalPerf.default 89 87 1.02:1
ChatWithPopoverPerf.default 196 192 1.02:1
DialogMinimalPerf.default 437 430 1.02:1
SkeletonMinimalPerf.default 207 202 1.02:1
TextMinimalPerf.default 189 186 1.02:1
VideoMinimalPerf.default 443 436 1.02:1
AccordionMinimalPerf.default 87 86 1.01:1
ButtonOverridesMissPerf.default 658 650 1.01:1
ChatMinimalPerf.default 445 441 1.01:1
CheckboxMinimalPerf.default 1130 1117 1.01:1
ProviderMergeThemesPerf.default 651 646 1.01:1
AttachmentMinimalPerf.default 82 82 1:1
ImageMinimalPerf.default 227 228 1:1
ItemLayoutMinimalPerf.default 694 692 1:1
ListMinimalPerf.default 307 308 1:1
ProviderMinimalPerf.default 203 202 1:1
BoxMinimalPerf.default 192 193 0.99:1
DropdownMinimalPerf.default 1427 1442 0.99:1
EmbedMinimalPerf.default 1852 1864 0.99:1
FlexMinimalPerf.default 156 157 0.99:1
MenuButtonMinimalPerf.default 946 954 0.99:1
TableManyItemsPerf.default 1089 1105 0.99:1
HeaderMinimalPerf.default 198 203 0.98:1
SegmentMinimalPerf.default 188 192 0.98:1
ListWith60ListItems.default 361 371 0.97:1
RosterPerf.default 1550 1597 0.97:1
StatusMinimalPerf.default 385 396 0.97:1
CardMinimalPerf.default 293 312 0.94:1
ListNestedPerf.default 306 326 0.94:1

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 630 631 5000
Breadcrumb mount 1701 1718 1000
Checkbox mount 1687 1723 5000
CheckboxBase mount 1429 1463 5000
ChoiceGroup mount 2956 2955 5000
ComboBox mount 687 657 1000
CommandBar mount 6416 6412 1000
ContextualMenu mount 12245 12081 1000
DefaultButton mount 795 781 5000
DetailsRow mount 2181 2242 5000
DetailsRowFast mount 2205 2230 5000
DetailsRowNoStyles mount 2005 2014 5000
Dialog mount 2806 2802 1000
DocumentCardTitle mount 231 232 1000
Dropdown mount 1991 1988 5000
FocusTrapZone mount 1152 1116 5000
FocusZone mount 1074 1063 5000
GroupedList mount 41315 42030 2
GroupedList virtual-rerender 20027 20007 2
GroupedList virtual-rerender-with-unmount 50235 51070 2
GroupedListV2 mount 219 218 2
GroupedListV2 virtual-rerender 207 211 2
GroupedListV2 virtual-rerender-with-unmount 221 218 2
IconButton mount 1120 1097 5000
Label mount 340 339 5000
Layer mount 2750 2760 5000
Link mount 395 403 5000
MenuButton mount 992 970 5000
MessageBar mount 21181 21301 5000
Nav mount 2041 1972 1000
OverflowSet mount 752 774 5000
Panel mount 1817 1814 1000
Persona mount 725 747 1000
Pivot mount 875 899 1000
PrimaryButton mount 908 925 5000
Rating mount 4584 4603 5000
SearchBox mount 933 912 5000
Shimmer mount 1894 1936 5000
Slider mount 1303 1363 5000
SpinButton mount 2902 2996 5000
Spinner mount 381 406 5000
SplitButton mount 1886 1866 5000
Stack mount 408 415 5000
StackWithIntrinsicChildren mount 865 853 5000
StackWithTextChildren mount 2650 2664 5000
SwatchColorPicker mount 6353 6331 5000
TagPicker mount 1442 1495 5000
Text mount 392 369 5000
TextField mount 918 928 5000
ThemeProvider mount 837 841 5000
ThemeProvider virtual-rerender 580 575 5000
ThemeProvider virtual-rerender-with-unmount 1272 1274 5000
Toggle mount 616 619 5000
buttonNative mount 183 185 5000

@Hotell Hotell merged commit 4662072 into microsoft:master Jun 6, 2024
21 checks passed
@Hotell Hotell deleted the ci/remove-cs-ci branch June 6, 2024 13:38
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Disable CodeSandbox CI?
4 participants