chore: normalize /scripts/* sourceRoot and use new performant 'type-check' for tools tagged libraries
#31475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
tools tagged libaries
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
May 24, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 620 | 628 | 5000 | |
| Button | mount | 299 | 314 | 5000 | |
| Field | mount | 1135 | 1130 | 5000 | |
| FluentProvider | mount | 715 | 691 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 31 | 35 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 84 | 81 | 10 | |
| MakeStyles | mount | 863 | 864 | 50000 | |
| Persona | mount | 1764 | 1757 | 5000 | |
| SpinButton | mount | 1371 | 1428 | 5000 | |
| SwatchPicker | mount | 1542 | 1574 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 89 | 86 | 1.03:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 92 | 79 | 1.16:1 |
| IconMinimalPerf.default | 415 | 368 | 1.13:1 |
| HeaderMinimalPerf.default | 219 | 198 | 1.11:1 |
| LoaderMinimalPerf.default | 197 | 179 | 1.1:1 |
| ButtonMinimalPerf.default | 96 | 88 | 1.09:1 |
| ButtonSlotsPerf.default | 329 | 310 | 1.06:1 |
| ItemLayoutMinimalPerf.default | 724 | 684 | 1.06:1 |
| RefMinimalPerf.default | 115 | 108 | 1.06:1 |
| TableMinimalPerf.default | 248 | 235 | 1.06:1 |
| TextMinimalPerf.default | 202 | 191 | 1.06:1 |
| AnimationMinimalPerf.default | 303 | 288 | 1.05:1 |
| RosterPerf.default | 1605 | 1526 | 1.05:1 |
| BoxMinimalPerf.default | 204 | 197 | 1.04:1 |
| FlexMinimalPerf.default | 167 | 161 | 1.04:1 |
| ImageMinimalPerf.default | 232 | 223 | 1.04:1 |
| ListMinimalPerf.default | 312 | 299 | 1.04:1 |
| RadioGroupMinimalPerf.default | 274 | 263 | 1.04:1 |
| ListNestedPerf.default | 334 | 323 | 1.03:1 |
| PortalMinimalPerf.default | 89 | 86 | 1.03:1 |
| ProviderMinimalPerf.default | 209 | 203 | 1.03:1 |
| ChatWithPopoverPerf.default | 195 | 191 | 1.02:1 |
| LabelMinimalPerf.default | 224 | 220 | 1.02:1 |
| ReactionMinimalPerf.default | 211 | 206 | 1.02:1 |
| StatusMinimalPerf.default | 387 | 380 | 1.02:1 |
| TreeWith60ListItems.default | 98 | 96 | 1.02:1 |
| CarouselMinimalPerf.default | 263 | 261 | 1.01:1 |
| DialogMinimalPerf.default | 444 | 438 | 1.01:1 |
| DividerMinimalPerf.default | 200 | 198 | 1.01:1 |
| DropdownManyItemsPerf.default | 399 | 394 | 1.01:1 |
| EmbedMinimalPerf.default | 1875 | 1852 | 1.01:1 |
| MenuButtonMinimalPerf.default | 964 | 954 | 1.01:1 |
| SliderMinimalPerf.default | 753 | 746 | 1.01:1 |
| ToolbarMinimalPerf.default | 544 | 537 | 1.01:1 |
| VideoMinimalPerf.default | 427 | 422 | 1.01:1 |
| AttachmentSlotsPerf.default | 632 | 630 | 1:1 |
| ChatMinimalPerf.default | 459 | 461 | 1:1 |
| DropdownMinimalPerf.default | 1413 | 1412 | 1:1 |
| FormMinimalPerf.default | 221 | 221 | 1:1 |
| LayoutMinimalPerf.default | 194 | 194 | 1:1 |
| ProviderMergeThemesPerf.default | 649 | 648 | 1:1 |
| SplitButtonMinimalPerf.default | 2240 | 2232 | 1:1 |
| CustomToolbarPrototype.default | 1493 | 1487 | 1:1 |
| TreeMinimalPerf.default | 495 | 495 | 1:1 |
| DatepickerMinimalPerf.default | 3566 | 3596 | 0.99:1 |
| GridMinimalPerf.default | 191 | 193 | 0.99:1 |
| HeaderSlotsPerf.default | 463 | 466 | 0.99:1 |
| PopupMinimalPerf.default | 351 | 354 | 0.99:1 |
| SkeletonMinimalPerf.default | 196 | 197 | 0.99:1 |
| CheckboxMinimalPerf.default | 1138 | 1158 | 0.98:1 |
| MenuMinimalPerf.default | 505 | 516 | 0.98:1 |
| TextAreaMinimalPerf.default | 288 | 294 | 0.98:1 |
| ListWith60ListItems.default | 361 | 374 | 0.97:1 |
| TableManyItemsPerf.default | 1103 | 1141 | 0.97:1 |
| ButtonOverridesMissPerf.default | 641 | 666 | 0.96:1 |
| CardMinimalPerf.default | 309 | 322 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 154 | 161 | 0.96:1 |
| TooltipMinimalPerf.default | 1230 | 1284 | 0.96:1 |
| AvatarMinimalPerf.default | 104 | 109 | 0.95:1 |
| InputMinimalPerf.default | 520 | 547 | 0.95:1 |
| SegmentMinimalPerf.default | 190 | 201 | 0.95:1 |
| AlertMinimalPerf.default | 154 | 164 | 0.94:1 |
| ListCommonPerf.default | 369 | 398 | 0.93:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 638 | 5000 | |
| Breadcrumb | mount | 1691 | 1699 | 1000 | |
| Checkbox | mount | 1682 | 1724 | 5000 | |
| CheckboxBase | mount | 1478 | 1506 | 5000 | |
| ChoiceGroup | mount | 2937 | 2996 | 5000 | |
| ComboBox | mount | 682 | 666 | 1000 | |
| CommandBar | mount | 6460 | 6524 | 1000 | |
| ContextualMenu | mount | 13270 | 13352 | 1000 | |
| DefaultButton | mount | 797 | 817 | 5000 | |
| DetailsRow | mount | 2204 | 2276 | 5000 | |
| DetailsRowFast | mount | 2212 | 2223 | 5000 | |
| DetailsRowNoStyles | mount | 2043 | 2030 | 5000 | |
| Dialog | mount | 2687 | 2827 | 1000 | |
| DocumentCardTitle | mount | 225 | 223 | 1000 | |
| Dropdown | mount | 1957 | 2018 | 5000 | |
| FocusTrapZone | mount | 1147 | 1129 | 5000 | |
| FocusZone | mount | 1085 | 1120 | 5000 | |
| GroupedList | mount | 41986 | 41844 | 2 | |
| GroupedList | virtual-rerender | 20270 | 20152 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51128 | 50908 | 2 | |
| GroupedListV2 | mount | 228 | 233 | 2 | |
| GroupedListV2 | virtual-rerender | 209 | 223 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 232 | 224 | 2 | |
| IconButton | mount | 1136 | 1097 | 5000 | |
| Label | mount | 343 | 347 | 5000 | |
| Layer | mount | 2748 | 2782 | 5000 | |
| Link | mount | 406 | 390 | 5000 | |
| MenuButton | mount | 1011 | 962 | 5000 | |
| MessageBar | mount | 21334 | 21432 | 5000 | |
| Nav | mount | 2017 | 2041 | 1000 | |
| OverflowSet | mount | 795 | 771 | 5000 | |
| Panel | mount | 1868 | 1861 | 1000 | |
| Persona | mount | 766 | 781 | 1000 | |
| Pivot | mount | 907 | 894 | 1000 | |
| PrimaryButton | mount | 923 | 931 | 5000 | |
| Rating | mount | 4782 | 4666 | 5000 | |
| SearchBox | mount | 930 | 928 | 5000 | |
| Shimmer | mount | 1917 | 1866 | 5000 | |
| Slider | mount | 1342 | 1349 | 5000 | |
| SpinButton | mount | 2947 | 2976 | 5000 | |
| Spinner | mount | 383 | 397 | 5000 | |
| SplitButton | mount | 1916 | 1854 | 5000 | |
| Stack | mount | 401 | 410 | 5000 | |
| StackWithIntrinsicChildren | mount | 840 | 858 | 5000 | |
| StackWithTextChildren | mount | 2649 | 2687 | 5000 | |
| SwatchColorPicker | mount | 6318 | 6372 | 5000 | |
| TagPicker | mount | 1435 | 1467 | 5000 | |
| Text | mount | 376 | 385 | 5000 | |
| TextField | mount | 947 | 948 | 5000 | |
| ThemeProvider | mount | 830 | 845 | 5000 | |
| ThemeProvider | virtual-rerender | 579 | 585 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1306 | 1289 | 5000 | |
| Toggle | mount | 631 | 614 | 5000 | |
| buttonNative | mount | 196 | 198 | 5000 |
Hotell
force-pushed
the
type-checking-perf/apply/scripts
branch
from
e4ac236 to
0791cc8
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
17 tasks
Hotell
force-pushed
the
type-checking-perf/apply/scripts
branch
from
bfe62d7 to
9288456
Compare
Hotell
changed the title
tools tagged libaries/scripts/* sourceRoot and use new performant 'type-check' for tools tagged libraries
Hotell
force-pushed
the
type-checking-perf/apply/scripts
branch
from
0755557 to
b209bf5
Compare
fabricteam
reviewed
May 28, 2024
Hotell
force-pushed
the
type-checking-perf/apply/scripts
branch
from
b209bf5 to
b04c6f3
Compare
1 task
ling1726
approved these changes
May 28, 2024
🕵 fluentuiv8 No visual regressions between this PR and main |
marcosmoura
approved these changes
May 29, 2024
AtishayMsft
approved these changes
May 29, 2024
|
admin merged = got majority of owners approval |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…-check' for `tools` tagged libraries (microsoft#31475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
/scripts/*packages have inconsistent structure:src/to host all package logicNew Behavior
sourceRootunder/srcscripts-gulppackage to be scoped under same domain ( also for consistent babel package behaviours and API )type-checkcommand viajust-scriptssplit-in-twogenerator (including dev Dependency additions to packages based on source AST )Related Issue(s)