Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts-lint-staged): correctly resolve package groupping based on provided git staged files #31490

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(scripts-lint-staged): correctly resolve package groupping based on provided git staged files #31490

merged 1 commit into from
Jun 4, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 28, 2024 •
edited
Loading

depends on:

Previous Behavior

lint-staged is broken for /scripts packages as it incorectly resolves file groupping to root package

New Behavior

  • lint-staged works across all scenarios
  • perf is improved as well as we no longer need to fetch all projects Map from nx Daemon on every commit

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 28, 2024
@Hotell Hotell changed the title Fix/lint staged resolution for eslint fix(scripts-lint-staged): correctly resolve package groupping based on provided git staged files May 28, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 28, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hotell Hotell force-pushed the fix/lint-staged-resolution-for-eslint branch from c7106f3 to 1776647 Compare May 29, 2024 16:46
Hotell
Hotell commented May 29, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review May 29, 2024 16:50
@Hotell Hotell requested a review from a team as a code owner May 29, 2024 16:50
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 31 38 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 633 655 5000
Button mount 299 301 5000
Field mount 1134 1123 5000
FluentProvider mount 710 712 5000
FluentProviderWithTheme mount 78 89 10
FluentProviderWithTheme virtual-rerender 31 38 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 70 71 10
MakeStyles mount 856 860 50000
Persona mount 1740 1723 5000
SpinButton mount 1388 1377 5000
SwatchPicker mount 1545 1575 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 87 76 1.14:1
BoxMinimalPerf.default 212 191 1.11:1
AvatarMinimalPerf.default 114 105 1.09:1
ChatDuplicateMessagesPerf.default 157 144 1.09:1
TreeWith60ListItems.default 91 84 1.08:1
ButtonMinimalPerf.default 94 88 1.07:1
ProviderMinimalPerf.default 207 194 1.07:1
ButtonSlotsPerf.default 309 291 1.06:1
ListNestedPerf.default 328 310 1.06:1
RefMinimalPerf.default 119 112 1.06:1
RadioGroupMinimalPerf.default 272 260 1.05:1
TextAreaMinimalPerf.default 304 290 1.05:1
AttachmentSlotsPerf.default 637 613 1.04:1
GridMinimalPerf.default 195 188 1.04:1
LabelMinimalPerf.default 225 216 1.04:1
PortalMinimalPerf.default 85 82 1.04:1
ChatMinimalPerf.default 448 435 1.03:1
CheckboxMinimalPerf.default 1166 1131 1.03:1
EmbedMinimalPerf.default 1874 1828 1.03:1
VideoMinimalPerf.default 434 422 1.03:1
DropdownMinimalPerf.default 1439 1408 1.02:1
FormMinimalPerf.default 232 228 1.02:1
ItemLayoutMinimalPerf.default 721 707 1.02:1
PopupMinimalPerf.default 350 342 1.02:1
TableManyItemsPerf.default 1111 1094 1.02:1
CarouselMinimalPerf.default 272 270 1.01:1
DatepickerMinimalPerf.default 3595 3549 1.01:1
FlexMinimalPerf.default 158 156 1.01:1
ListCommonPerf.default 394 390 1.01:1
MenuButtonMinimalPerf.default 972 960 1.01:1
SliderMinimalPerf.default 740 733 1.01:1
SplitButtonMinimalPerf.default 2262 2243 1.01:1
StatusMinimalPerf.default 398 396 1.01:1
ToolbarMinimalPerf.default 540 534 1.01:1
AnimationMinimalPerf.default 304 305 1:1
DialogMinimalPerf.default 446 446 1:1
DividerMinimalPerf.default 198 198 1:1
HeaderSlotsPerf.default 463 463 1:1
ImageMinimalPerf.default 218 217 1:1
MenuMinimalPerf.default 505 506 1:1
TooltipMinimalPerf.default 1258 1257 1:1
TreeMinimalPerf.default 484 486 1:1
CardMinimalPerf.default 310 314 0.99:1
LayoutMinimalPerf.default 204 206 0.99:1
ListMinimalPerf.default 307 309 0.99:1
LoaderMinimalPerf.default 192 193 0.99:1
SegmentMinimalPerf.default 201 203 0.99:1
SkeletonMinimalPerf.default 197 198 0.99:1
DropdownManyItemsPerf.default 393 403 0.98:1
InputMinimalPerf.default 529 539 0.98:1
RosterPerf.default 1521 1545 0.98:1
ProviderMergeThemesPerf.default 634 650 0.98:1
IconMinimalPerf.default 388 397 0.98:1
TextMinimalPerf.default 190 193 0.98:1
TableMinimalPerf.default 229 236 0.97:1
CustomToolbarPrototype.default 1490 1534 0.97:1
ListWith60ListItems.default 365 380 0.96:1
AlertMinimalPerf.default 158 167 0.95:1
ButtonOverridesMissPerf.default 654 686 0.95:1
HeaderMinimalPerf.default 200 211 0.95:1
ReactionMinimalPerf.default 202 219 0.92:1
ChatWithPopoverPerf.default 187 205 0.91:1
AccordionMinimalPerf.default 76 93 0.82:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 633 614 5000
Breadcrumb mount 1680 1684 1000
Checkbox mount 1724 1719 5000
CheckboxBase mount 1482 1498 5000
ChoiceGroup mount 3005 2970 5000
ComboBox mount 685 682 1000
CommandBar mount 6478 6515 1000
ContextualMenu mount 13403 13346 1000
DefaultButton mount 839 813 5000
DetailsRow mount 2223 2235 5000
DetailsRowFast mount 2191 2222 5000
DetailsRowNoStyles mount 2038 2064 5000
Dialog mount 2792 2812 1000
DocumentCardTitle mount 216 238 1000
Dropdown mount 2031 2020 5000
FocusTrapZone mount 1136 1143 5000
FocusZone mount 1097 1095 5000
GroupedList mount 41728 42095 2
GroupedList virtual-rerender 20199 20130 2
GroupedList virtual-rerender-with-unmount 50724 51317 2
GroupedListV2 mount 234 233 2
GroupedListV2 virtual-rerender 212 221 2
GroupedListV2 virtual-rerender-with-unmount 223 237 2
IconButton mount 1137 1137 5000
Label mount 345 346 5000
Layer mount 2790 2732 5000
Link mount 390 401 5000
MenuButton mount 1016 986 5000
MessageBar mount 21378 21252 5000
Nav mount 2068 2048 1000
OverflowSet mount 793 775 5000
Panel mount 1772 1784 1000
Persona mount 753 773 1000
Pivot mount 907 907 1000
PrimaryButton mount 919 932 5000
Rating mount 4723 4692 5000
SearchBox mount 908 908 5000
Shimmer mount 1916 1868 5000
Slider mount 1322 1334 5000
SpinButton mount 3017 3025 5000
Spinner mount 399 394 5000
SplitButton mount 1877 1935 5000
Stack mount 421 414 5000
StackWithIntrinsicChildren mount 878 855 5000
StackWithTextChildren mount 2654 2635 5000
SwatchColorPicker mount 6304 6463 5000
TagPicker mount 1470 1503 5000
Text mount 374 376 5000
TextField mount 945 917 5000
ThemeProvider mount 849 862 5000
ThemeProvider virtual-rerender 594 587 5000
ThemeProvider virtual-rerender-with-unmount 1316 1308 5000
Toggle mount 617 630 5000
buttonNative mount 197 191 5000

@Hotell Hotell requested review from marcosmoura May 30, 2024 15:06
@Hotell Hotell merged commit b2c3a81 into microsoft:master Jun 4, 2024
22 checks passed
@Hotell Hotell deleted the fix/lint-staged-resolution-for-eslint branch June 4, 2024 10:54
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
fix(scripts-lint-staged): correctly resolve package groupping based o…
d1feacc 
…n provided git staged files (microsoft#31490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
Area: Build System Area: Linting
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @marcosmoura