chore: normalize /scripts/* sourceRoot and use new performant 'type…

…-check' for `tools` tagged libraries (#31475)

.vscode/launch.json

@@ -5,7 +5,7 @@
       "name": "Debug test",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceRoot}/scripts/executors/debug-test.js",
+      "program": "${workspaceRoot}/scripts/executors/src/debug-test.js",
       "cwd": "${fileDirname}",
       "stopOnEntry": false,
       "args": ["-i", "--watch"],
@@ -22,7 +22,7 @@
       "name": "Debug current open test",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceRoot}/scripts/executors/debug-test.js",
+      "program": "${workspaceRoot}/scripts/executors/src/debug-test.js",
       "cwd": "${fileDirname}",
       "stopOnEntry": false,
       "args": ["-i", "--testPathPattern=\\b${fileBasenameNoExtension}", "--watch"],
@@ -39,7 +39,7 @@
       "name": "Debug current open test (v0)",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceRoot}/scripts/executors/debug-test.js",
+      "program": "${workspaceRoot}/scripts/executors/src/debug-test.js",
       "cwd": "${fileDirname}",
       "stopOnEntry": false,
       "args": ["-i", "--testPathPattern=\\b${fileBasenameNoExtension}", "--watch"],
@@ -128,7 +128,7 @@
       "protocol": "inspector",
       "cwd": "${workspaceRoot}",
       "args": [
-        "${workspaceRoot}/scripts/update-release-notes/index.ts",
+        "${workspaceRoot}/scripts/update-release-notes/src/index.ts",
         "--token",
         // For local testing, generate a personal access token (https://github.com/settings/tokens)
         // and replace "your token here" with the token. DO NOT COMMIT YOUR TOKEN!
@@ -137,7 +137,7 @@
         "--age",
         "10"
       ],
-      "runtimeArgs": ["--nolazy", "--inspect", "-r", "${workspaceRoot}/scripts/ts-node/register"],
+      "runtimeArgs": ["--nolazy", "--inspect", "-r", "${workspaceRoot}/scripts/ts-node/src/register"],
       "env": {
         "NODE_ENV": "development"
       },

azure-pipelines.release-vnext-nightly.yml

@@ -97,7 +97,7 @@ extends:
                 displayName: yarn build
 
               - script: |
-                  yarn publish:beachball -n $(npmToken) --no-push --tag nightly --config scripts/beachball/release-vNext.config.js
+                  yarn publish:beachball -n $(npmToken) --no-push --tag nightly --config scripts/beachball/src/release-vNext.config.js
                   git reset --hard origin/master
                 displayName: Publish changes and bump versions
 

azure-pipelines.release-vnext.yml

@@ -84,14 +84,14 @@ extends:
                 displayName: yarn build
 
               - script: |
-                  yarn publish:beachball -n $(npmToken) --config scripts/beachball/release-vNext.config.js
+                  yarn publish:beachball -n $(npmToken) --config scripts/beachball/src/release-vNext.config.js
                   git reset --hard origin/master
                 env:
                   GITHUB_PAT: $(githubPAT)
                 displayName: Publish changes and bump versions
 
               - script: |
-                  node -r ./scripts/ts-node/register scripts/executors/tag-react-components.ts --token $(npmToken)
+                  node -r ./scripts/ts-node/src/register scripts/executors/src/tag-react-components.ts --token $(npmToken)
                 displayName: Tag prelease packages with prerelease tag
                 continueOnError: true
 
@@ -102,7 +102,7 @@ extends:
 
               # TODO update release notes script for v9
               # - script: |
-              #     node -r ./scripts/ts-node/register ./scripts/update-release-notes/index.ts --token=$(githubPAT) --apply --debug
+              #     node -r ./scripts/ts-node/src/register ./scripts/update-release-notes/src/index.ts --token=$(githubPAT) --apply --debug
               #   displayName: 'Update github release notes'
 
               # This would usually be run automatically (via a pipeline decorator from an extension), but the

azure-pipelines.release.web-components.yml

@@ -75,7 +75,7 @@ extends:
                 displayName: Build, [test], Lint
 
               - script: |
-                  yarn publish:beachball -n $(npmToken) --config scripts/beachball/release-web-components.config.js
+                  yarn publish:beachball -n $(npmToken) --config scripts/beachball/src/release-web-components.config.js
                   git reset --hard origin/master
                 env:
                   GITHUB_PAT: $(githubPAT)

azure-pipelines.release.yml

@@ -120,7 +120,7 @@ extends:
                 displayName: yarn bundle
 
               - script: |
-                  yarn publish:beachball -n $(npmToken) --config scripts/beachball/release-v8.config.js
+                  yarn publish:beachball -n $(npmToken) --config scripts/beachball/src/release-v8.config.js
                   git reset --hard origin/master
                 env:
                   GITHUB_PAT: $(githubPAT)
@@ -155,7 +155,7 @@ extends:
               # Run this near the end because it's more likely to fail than the artifact upload tasks, and its
               # failure doesn't need to block anything else
               - script: |
-                  node -r ./scripts/ts-node/register ./scripts/update-release-notes/index.ts --token=$(githubPAT) --apply --debug
+                  node -r ./scripts/ts-node/src/register ./scripts/update-release-notes/src/index.ts --token=$(githubPAT) --apply --debug
                 displayName: 'Update github release notes'
 
               - template: .devops/templates/cleanup.yml@self

change/@fluentui-react-27671eeb-1fa7-49ce-8068-e6150048b1fa.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: normalize all scripts source to live under /src",
+  "packageName": "@fluentui/react",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-react-charting-6f19b95b-48d2-4551-8a48-3d536dabf40f.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: normalize all scripts source to live under /src",
+  "packageName": "@fluentui/react-charting",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@fluentui-tokens-15117ef6-b2bf-4271-9818-c5f7ede5a743.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "chore: normalize all scripts source to live under /src",
+  "packageName": "@fluentui/tokens",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

docs/react-v9/contributing/rfcs/shared/build-system/08-type-checking-perf-improvements.md

@@ -107,7 +107,7 @@ This dts generation can be done in 2 ways:
 > EXAMPLE PR: https://github.com/microsoft/fluentui/pull/28002
 
 ```yml
-- script: node ./scripts/executors/type-check-ci-hack.js --base $(targetBranch)
+- script: node ./scripts/executors/src/type-check-ci-hack.js --base $(targetBranch)
     displayName: type-check perf preparation
 - script: yarn buildci $(sinceArg)
 ```

lint-staged.config.js

@@ -10,7 +10,7 @@ const commands = {
    * - respect ignore files (which eslint doesn't do by default when passed a specific file path)
    * - match the set of files that are linted by the package's normal `lint` command
    */
-  lint: 'node ./scripts/lint-staged/eslint',
+  lint: 'node ./scripts/lint-staged/src/eslint',
 };
 
 // https://www.npmjs.com/package/lint-staged

package.json

@@ -20,35 +20,35 @@
     "bundle": "lage bundle --verbose",
     "change": "beachball change --no-commit",
     "check:change": "beachball check",
-    "check:modified-files": "node -r ./scripts/ts-node/register ./scripts/executors/check-for-modified-files",
-    "check:affected": "node ./scripts/executors/checkIfPackagesAffected.js",
+    "check:modified-files": "node -r ./scripts/ts-node/src/register ./scripts/executors/src/check-for-modified-files",
+    "check:affected": "node ./scripts/executors/src/checkIfPackagesAffected.js",
     "check:installed-dependencies-versions": "satisfied --no-peers --skip-invalid",
     "clean": "lage clean --verbose",
     "code-style": "lage code-style --verbose",
-    "codepen": "cd packages/react && node ../../scripts/executors/local-codepen.js",
-    "copy-notices": "node scripts/generators/copy-notices.js",
+    "codepen": "cd packages/react && node ../../scripts/executors/src/local-codepen.js",
+    "copy-notices": "node scripts/generators/src/copy-notices.js",
     "create-component": "yarn nx g @fluentui/workspace-plugin:react-component",
     "create-package": "yarn nx g @fluentui/workspace-plugin:react-library",
     "e2e": "lage e2e --verbose --concurrency=1",
-    "format": "node scripts/executors/format.js",
-    "generate-version-files": "node -r ./scripts/ts-node/register ./scripts/generators/generate-version-files",
+    "format": "node scripts/executors/src/format.js",
+    "generate-version-files": "node -r ./scripts/ts-node/src/register ./scripts/generators/src/generate-version-files",
     "lint": "lage lint --verbose",
     "lint:log": "FORCE_COLOR=0 yarn lint > lint.log 2>&1",
-    "postinstall": "node ./scripts/package-manager/postinstall.js",
-    "preinstall": "node ./scripts/package-manager/use-yarn-please.js",
+    "postinstall": "node ./scripts/package-manager/src/postinstall.js",
+    "preinstall": "node ./scripts/package-manager/src/use-yarn-please.js",
     "publish:beachball": "beachball publish -b origin/master --access public -y",
-    "rebuild": "node ./scripts/executors/invalidate-just-cache.js && yarn build --reset-cache",
+    "rebuild": "node ./scripts/executors/src/invalidate-just-cache.js && yarn build --reset-cache",
     "northstar:release": "northstar-release",
     "northstar:build:docs": "yarn workspace @fluentui/docs build",
     "northstar:start": "yarn workspace @fluentui/docs start",
     "northstar:perf": "yarn workspace @fluentui/perf perf:test",
     "northstar:stats:build": "gulp stats",
     "northstar:stats:save": "gulp stats:save",
     "northstar:test:circulars": "gulp test:circulars:run",
-    "rename-package": "node -r ./scripts/ts-node/register ./scripts/generators/rename-package.ts",
-    "run:published": "node ./scripts/executors/runPublished.js",
-    "scrub": "node ./scripts/executors/scrub.js",
-    "start": "node ./scripts/executors/start.js",
+    "rename-package": "node -r ./scripts/ts-node/src/register ./scripts/generators/src/rename-package.ts",
+    "run:published": "node ./scripts/executors/src/runPublished.js",
+    "scrub": "node ./scripts/executors/src/scrub.js",
+    "start": "node ./scripts/executors/src/start.js",
     "test": "lage test --verbose",
     "update-snapshots": "lage update-snapshots --verbose"
   },

packages/react-charting/package.json

@@ -20,7 +20,7 @@
     "test": "cross-env TZ=UTC just-scripts test",
     "just": "just-scripts",
     "clean": "just-scripts clean",
-    "codepen": "node ../../scripts/executors/local-codepen.js",
+    "codepen": "node ../../scripts/executors/src/local-codepen.js",
     "code-style": "just-scripts code-style",
     "start": "just-scripts dev:storybook",
     "start:legacy": "just-scripts dev",

packages/react/package.json

@@ -21,7 +21,7 @@
     "build-storybook": "cross-env NODE_OPTIONS=--max-old-space-size=3072 just-scripts storybook:build",
     "clean": "just-scripts clean",
     "code-style": "just-scripts code-style",
-    "codepen": "node ../../scripts/executors/local-codepen.js",
+    "codepen": "node ../../scripts/executors/src/local-codepen.js",
     "e2e": "yarn workspace @fluentui/react-examples cypress run --component",
     "e2e:local": "yarn workspace @fluentui/react-examples cypress open --component",
     "just": "just-scripts",

packages/tokens/package.json

@@ -18,7 +18,7 @@
     "just": "just-scripts",
     "lint": "just-scripts lint",
     "test": "jest --passWithNoTests",
-    "token-pipeline": "node -r ../../scripts/ts-node/register ../../scripts/generators/token-pipeline.ts",
+    "token-pipeline": "node -r ../../scripts/ts-node/src/register ../../scripts/generators/src/token-pipeline.ts",
     "type-check": "just-scripts type-check",
     "generate-api": "just-scripts generate-api"
   },

scripts/api-extractor/package.json

@@ -6,9 +6,10 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js .",
+    "lint": "eslint --ext .ts,.js ./src",
     "test": "jest --passWithNoTests",
-    "type-check": "tsc -b tsconfig.json"
+    "type-check": "just-scripts type-check"
   },
-  "dependencies": {}
+  "dependencies": {},
+  "devDependencies": {}
 }

scripts/api-extractor/src/index.js

@@ -0,0 +1 @@
+module.exports = {};

scripts/api-extractor/tsconfig.lib.json

@@ -7,5 +7,5 @@
     "types": ["node"]
   },
   "exclude": ["**/*.spec.ts", "**/*.test.ts"],
-  "include": ["./**/*.ts", "./**/*.js"]
+  "include": ["./src/**/*.ts", "./src/**/*.js"]
 }

scripts/babel/just.config.ts

@@ -0,0 +1,3 @@
+import { preset } from '@fluentui/scripts-tasks';
+
+preset();

scripts/babel/package.json

@@ -2,13 +2,28 @@
   "name": "@fluentui/scripts-babel",
   "version": "0.0.1",
   "private": true,
-  "main": "index.js",
+  "main": "src/index.js",
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js .",
+    "lint": "eslint --ext .ts,.js ./src",
     "test": "jest --passWithNoTests",
-    "type-check": "tsc -b tsconfig.json"
+    "type-check": "just-scripts type-check"
   },
-  "dependencies": {}
+  "dependencies": {},
+  "devDependencies": {},
+  "exports": {
+    ".": {
+      "require": "./src/index.js",
+      "import": "./src/index.js"
+    },
+    "./register": {
+      "require": "./register.js",
+      "import": "./register.js"
+    },
+    "./preset-v9": {
+      "require": "./src/preset-v9.js",
+      "import": "./src/preset-v9.js"
+    }
+  }
 }

scripts/babel/project.json

@@ -1,7 +1,7 @@
 {
   "name": "@fluentui/scripts-babel",
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
-  "sourceRoot": "scripts/babel",
+  "sourceRoot": "scripts/babel/src",
   "projectType": "library",
   "tags": ["tools"]
 }

scripts/babel/index.js → scripts/babel/src/index.js

@@ -1,3 +1,7 @@
+/**
+ * This files is used solely for react-northstar projects. Please don't any new logic here
+ */
+
 /** @typedef {import('@babel/core').TransformOptions['caller']} Caller */
 
 const isNodeCaller = (/** @type {Caller}*/ caller) => {

scripts/babel/tsconfig.lib.json

@@ -7,5 +7,5 @@
     "types": ["node"]
   },
   "exclude": ["**/*.spec.ts", "**/*.test.ts"],
-  "include": ["./**/*.ts", "./**/*.js"]
+  "include": ["./src/**/*.ts", "./src/**/*.js"]
 }

scripts/beachball/just.config.ts

@@ -0,0 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { preset } from '@fluentui/scripts-tasks';
+
+preset();

scripts/beachball/package.json

@@ -2,17 +2,18 @@
   "name": "@fluentui/scripts-beachball",
   "version": "0.0.1",
   "private": true,
-  "main": "index.js",
+  "main": "src/index.js",
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js .",
+    "lint": "eslint --ext .ts,.js ./src",
     "test": "jest --passWithNoTests",
-    "type-check": "tsc -b tsconfig.json"
+    "type-check": "just-scripts type-check"
   },
   "dependencies": {
     "@fluentui/scripts-github": "*",
     "@fluentui/scripts-monorepo": "*",
     "@fluentui/scripts-ts-node": "*"
-  }
+  },
+  "devDependencies": {}
 }

scripts/beachball/project.json

@@ -1,7 +1,7 @@
 {
   "name": "@fluentui/scripts-beachball",
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
-  "sourceRoot": "scripts/beachball",
+  "sourceRoot": "scripts/beachball/src",
   "projectType": "library",
   "tags": ["tools"]
 }

scripts/beachball/register.js → scripts/beachball/src/register.js

@@ -6,6 +6,6 @@ exports.register = register;
 function register() {
   if (process.env.NODE_ENV !== 'test') {
     // @ts-expect-error - ts-node/register doesn't provide types so this would error
-    require('@fluentui/scripts-ts-node/register');
+    require('@fluentui/scripts-ts-node/src/register');
   }
 }

scripts/beachball/shared.config.ts → scripts/beachball/src/shared.config.ts

@@ -6,8 +6,8 @@ import type { BeachballConfig } from 'beachball';
 
 import { renderEntry, renderHeader } from './customRenderers';
 
-const baseConfig: typeof import('./base.config.json') = JSON.parse(
-  fs.readFileSync(path.resolve(__dirname, 'base.config.json'), { encoding: 'utf8' }),
+const baseConfig: typeof import('../base.config.json') = JSON.parse(
+  fs.readFileSync(path.resolve(__dirname, '../base.config.json'), { encoding: 'utf8' }),
 );
 
 export const config: typeof baseConfig & Required<Pick<BeachballConfig, 'changelog' | 'hooks'>> = {

scripts/beachball/tsconfig.lib.json

@@ -7,5 +7,5 @@
     "types": ["node", "jest"]
   },
   "exclude": ["**/*.spec.ts", "**/*.test.ts"],
-  "include": ["./**/*.ts", "./**/*.js"]
+  "include": ["./src/**/*.ts", "./src/**/*.js"]
 }

scripts/cypress/just.config.ts

@@ -0,0 +1,3 @@
+import { preset } from '@fluentui/scripts-tasks';
+
+preset();

scripts/cypress/package.json

@@ -6,9 +6,10 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js .",
+    "lint": "eslint --ext .ts,.js ./src",
     "test": "jest --passWithNoTests",
-    "type-check": "tsc -b tsconfig.json"
+    "type-check": "just-scripts type-check"
   },
-  "dependencies": {}
+  "dependencies": {},
+  "devDependencies": {}
 }

scripts/dangerjs/just.config.ts

@@ -0,0 +1,3 @@
+import { preset } from '@fluentui/scripts-tasks';
+
+preset();