Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-examples): remove using v8 deps when bundling vNext ReactCo… #19021

Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 20, 2021

…mponents storybook

Pull request checklist

  • [ ] Addresses an existing issue: Fixes
  • [ ] Include a change request file using $ yarn change

Description of changes

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against fa1ce5e27c9e4b95542878c7827c004c058641ee

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19fa41f:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 20, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: fa1ce5e27c9e4b95542878c7827c004c058641ee (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 841 822 5000
BaseButton mount 969 988 5000
Breadcrumb mount 2740 2647 1000
ButtonNext mount 561 549 5000
Checkbox mount 1701 1702 5000
CheckboxBase mount 1447 1448 5000
ChoiceGroup mount 5170 5138 5000
ComboBox mount 1066 1017 1000
CommandBar mount 10529 10579 1000
ContextualMenu mount 6550 6369 1000
DefaultButton mount 1300 1335 5000
DetailsRow mount 3988 4064 5000
DetailsRowFast mount 3987 4021 5000
DetailsRowNoStyles mount 3852 3880 5000
Dialog mount 2405 2288 1000
DocumentCardTitle mount 160 171 1000
Dropdown mount 3619 3606 5000
FluentProviderNext mount 7154 7303 5000
FocusTrapZone mount 1856 1930 5000
FocusZone mount 1964 1898 5000
IconButton mount 1946 1945 5000
Label mount 368 374 5000
Layer mount 1907 1938 5000
Link mount 492 510 5000
MakeStyles mount 1889 1848 50000
MenuButton mount 1606 1595 5000
MessageBar mount 2128 2092 5000
Nav mount 3729 3547 1000
OverflowSet mount 1127 1124 5000
Panel mount 2188 2219 1000
Persona mount 897 891 1000
Pivot mount 1502 1542 1000
PrimaryButton mount 1412 1398 5000
Rating mount 8558 8829 5000
SearchBox mount 1442 1477 5000
Shimmer mount 2766 2707 5000
Slider mount 2083 2083 5000
SpinButton mount 5378 5246 5000
Spinner mount 437 429 5000
SplitButton mount 3527 3414 5000
Stack mount 561 538 5000
StackWithIntrinsicChildren mount 1700 1709 5000
StackWithTextChildren mount 5111 5118 5000
SwatchColorPicker mount 10995 11009 5000
Tabs mount 1482 1489 1000
TagPicker mount 2604 2604 5000
TeachingBubble mount 12716 12622 5000
Text mount 481 489 5000
TextField mount 1535 1542 5000
ThemeProvider mount 1328 1282 5000
ThemeProvider virtual-rerender 675 650 5000
Toggle mount 935 916 5000
buttonNative mount 133 122 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 256 228 1.12:1
ChatDuplicateMessagesPerf.default 348 316 1.1:1
SkeletonMinimalPerf.default 400 369 1.08:1
FlexMinimalPerf.default 311 294 1.06:1
ItemLayoutMinimalPerf.default 1391 1314 1.06:1
ListNestedPerf.default 642 604 1.06:1
IconMinimalPerf.default 710 669 1.06:1
TextMinimalPerf.default 401 380 1.06:1
TreeWith60ListItems.default 196 185 1.06:1
SegmentMinimalPerf.default 382 365 1.05:1
TreeMinimalPerf.default 875 837 1.05:1
AnimationMinimalPerf.default 443 427 1.04:1
BoxMinimalPerf.default 376 363 1.04:1
ButtonMinimalPerf.default 188 180 1.04:1
CheckboxMinimalPerf.default 2946 2828 1.04:1
ImageMinimalPerf.default 428 412 1.04:1
ReactionMinimalPerf.default 420 403 1.04:1
TextAreaMinimalPerf.default 605 580 1.04:1
ChatWithPopoverPerf.default 407 394 1.03:1
DatepickerMinimalPerf.default 5976 5828 1.03:1
FormMinimalPerf.default 455 442 1.03:1
HeaderMinimalPerf.default 386 376 1.03:1
ListCommonPerf.default 716 695 1.03:1
LoaderMinimalPerf.default 745 720 1.03:1
ProviderMinimalPerf.default 1125 1089 1.03:1
AlertMinimalPerf.default 294 289 1.02:1
AttachmentSlotsPerf.default 1139 1115 1.02:1
ButtonOverridesMissPerf.default 1831 1797 1.02:1
CardMinimalPerf.default 622 607 1.02:1
DialogMinimalPerf.default 824 811 1.02:1
InputMinimalPerf.default 1375 1351 1.02:1
LabelMinimalPerf.default 438 430 1.02:1
MenuMinimalPerf.default 923 909 1.02:1
PortalMinimalPerf.default 182 179 1.02:1
TableMinimalPerf.default 461 454 1.02:1
ToolbarMinimalPerf.default 1060 1038 1.02:1
TooltipMinimalPerf.default 1113 1090 1.02:1
CarouselMinimalPerf.default 514 511 1.01:1
DropdownMinimalPerf.default 3225 3201 1.01:1
MenuButtonMinimalPerf.default 1788 1769 1.01:1
PopupMinimalPerf.default 611 603 1.01:1
StatusMinimalPerf.default 763 754 1.01:1
TableManyItemsPerf.default 2217 2191 1.01:1
CustomToolbarPrototype.default 4139 4093 1.01:1
AccordionMinimalPerf.default 163 163 1:1
AvatarMinimalPerf.default 214 214 1:1
DropdownManyItemsPerf.default 748 746 1:1
EmbedMinimalPerf.default 4351 4331 1:1
HeaderSlotsPerf.default 826 829 1:1
LayoutMinimalPerf.default 400 400 1:1
ListMinimalPerf.default 565 567 1:1
ListWith60ListItems.default 699 696 1:1
RadioGroupMinimalPerf.default 486 487 1:1
VideoMinimalPerf.default 685 684 1:1
ChatMinimalPerf.default 725 729 0.99:1
RosterPerf.default 1285 1301 0.99:1
SplitButtonMinimalPerf.default 4222 4276 0.99:1
DividerMinimalPerf.default 386 392 0.98:1
ProviderMergeThemesPerf.default 1670 1711 0.98:1
GridMinimalPerf.default 364 376 0.97:1
SliderMinimalPerf.default 1603 1656 0.97:1
ButtonSlotsPerf.default 618 646 0.96:1
AttachmentMinimalPerf.default 165 173 0.95:1

@Hotell Hotell merged commit 9b84c04 into microsoft:master Jul 20, 2021
@Hotell Hotell added this to the July Project Cycle Q2 2021 milestone Jul 20, 2021
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants