Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-examples): remove using v8 deps when bundling vNext ReactCo… #19021

Merged
merged 1 commit into from
Jul 20, 2021
Merged

fix(react-examples): remove using v8 deps when bundling vNext ReactCo… #19021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-examples/.storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const storyOrder = [

addDecorator(withInfo);
addDecorator(withPerformance);
addDecorator(withKeytipLayer);
addCustomDecorators();

addParameters({
Expand Down Expand Up @@ -69,6 +68,13 @@ function addCustomDecorators() {
customDecorators.add(withFluentProvider).add(withStrictMode);
}

// add decorators to all stories except vNext react-components suite
// - this is needed so we don't creep v8 dependencies to vNext deps
// - `withKeytipLayer` is v8 dependency - including it to vNext suite was causing CI errors - `Cannot read property 'disableGlobalClassNames' of undefined `
if (packageNamePlaceholder !== 'react-components') {
customDecorators.add(withKeytipLayer);
}

customDecorators.forEach(decorator => addDecorator(decorator));
}

Expand Down