Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-tooltip: Migration to new DX #18977

Merged
merged 5 commits into from
Jul 21, 2021
Merged

react-tooltip: Migration to new DX #18977

merged 5 commits into from
Jul 21, 2021

Conversation

tringakrasniqi
Copy link
Contributor

@tringakrasniqi tringakrasniqi commented Jul 16, 2021 •
edited
Loading

Pull request checklist

Description of changes

Migration to new DX

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 16, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fbcb40:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 16, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: af8ea63220c598dbc4addfea04d39a6a3d4fe851 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 16, 2021 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 78.403 kB
23.179 kB
react-avatar
Avatar		 54.293 kB
14.665 kB
react-badge
Badge		 24.393 kB
7.174 kB
react-badge
CounterBadge		 27.206 kB
7.862 kB
react-badge
PresenseBadge		 237 B
177 B
react-button
Button		 25.967 kB
8.231 kB
react-button
CompoundButton		 31.409 kB
9.107 kB
react-button
MenuButton		 27.552 kB
8.732 kB
react-button
ToggleButton		 36.393 kB
8.907 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 197.875 kB
57.818 kB
react-components
react-components: FluentProvider & webLightTheme		 35.513 kB
11.437 kB
react-divider
Divider		 15.889 kB
5.747 kB
react-image
Image		 10.642 kB
4.264 kB
react-label
Label		 28.622 kB
10.654 kB
react-link
Link		 14.715 kB
6.012 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.557 kB
1.202 kB
react-menu
Menu (including children components)		 113.933 kB
34.39 kB
react-menu
Menu (including selectable components)		 115.945 kB
34.65 kB
react-popover
Popover		 140.924 kB
41.969 kB
react-portal
Portal		 7.78 kB
2.672 kB
react-positioning
usePopper		 23.141 kB
7.931 kB
react-provider
FluentProvider		 16.235 kB
5.972 kB
react-theme
Teams: all themes		 31.935 kB
6.49 kB
react-theme
Teams: Light theme		 19.527 kB
5.504 kB
react-tooltip
Tooltip		 44.524 kB
15.221 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against af8ea63220c598dbc4addfea04d39a6a3d4fe851

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 16, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 771 783 5000
BaseButton mount 818 859 5000
Breadcrumb mount 2464 2491 1000
ButtonNext mount 498 484 5000
Checkbox mount 1433 1439 5000
CheckboxBase mount 1216 1200 5000
ChoiceGroup mount 4562 4463 5000
ComboBox mount 919 921 1000
CommandBar mount 9571 9613 1000
ContextualMenu mount 5929 5892 1000
DefaultButton mount 1055 1065 5000
DetailsRow mount 3523 3498 5000
DetailsRowFast mount 3513 3474 5000
DetailsRowNoStyles mount 3345 3309 5000
Dialog mount 2013 2020 1000
DocumentCardTitle mount 135 124 1000
Dropdown mount 3078 3029 5000
FluentProviderNext mount 6911 6934 5000
FocusTrapZone mount 1703 1702 5000
FocusZone mount 1714 1727 5000
IconButton mount 1660 1638 5000
Label mount 314 310 5000
Layer mount 1662 1702 5000
Link mount 440 442 5000
MakeStyles mount 1730 1705 50000
MenuButton mount 1386 1407 5000
MessageBar mount 1909 1909 5000
Nav mount 3039 3084 1000
OverflowSet mount 985 982 5000
Panel mount 1978 1997 1000
Persona mount 772 788 1000
Pivot mount 1334 1333 1000
PrimaryButton mount 1204 1196 5000
Rating mount 7180 7149 5000
SearchBox mount 1236 1232 5000
Shimmer mount 2376 2404 5000
Slider mount 1820 1832 5000
SpinButton mount 4783 4685 5000
Spinner mount 409 404 5000
SplitButton mount 3027 2969 5000
Stack mount 458 478 5000
StackWithIntrinsicChildren mount 1480 1475 5000
StackWithTextChildren mount 4248 4259 5000
SwatchColorPicker mount 9639 9790 5000
Tabs mount 1330 1321 1000
TagPicker mount 2280 2238 5000
TeachingBubble mount 11343 11287 5000
Text mount 404 391 5000
TextField mount 1281 1297 5000
ThemeProvider mount 1137 1104 5000
ThemeProvider virtual-rerender 573 565 5000
Toggle mount 750 760 5000
buttonNative mount 110 106 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 165 157 1.05:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatWithPopoverPerf.default 336 301 1.12:1
AnimationMinimalPerf.default 407 375 1.09:1
FormMinimalPerf.default 388 356 1.09:1
PortalMinimalPerf.default 178 163 1.09:1
AvatarMinimalPerf.default 185 176 1.05:1
ImageMinimalPerf.default 353 340 1.04:1
ToolbarMinimalPerf.default 888 855 1.04:1
ListNestedPerf.default 528 515 1.03:1
CarouselMinimalPerf.default 436 426 1.02:1
ChatMinimalPerf.default 615 601 1.02:1
FlexMinimalPerf.default 265 261 1.02:1
ListWith60ListItems.default 603 590 1.02:1
MenuMinimalPerf.default 794 781 1.02:1
ProviderMergeThemesPerf.default 1610 1574 1.02:1
RadioGroupMinimalPerf.default 423 414 1.02:1
ReactionMinimalPerf.default 351 343 1.02:1
SkeletonMinimalPerf.default 327 321 1.02:1
IconMinimalPerf.default 592 582 1.02:1
TableManyItemsPerf.default 1817 1789 1.02:1
TextMinimalPerf.default 327 321 1.02:1
AccordionMinimalPerf.default 143 141 1.01:1
ButtonOverridesMissPerf.default 1635 1622 1.01:1
DatepickerMinimalPerf.default 5138 5101 1.01:1
DropdownManyItemsPerf.default 637 628 1.01:1
EmbedMinimalPerf.default 3953 3933 1.01:1
HeaderSlotsPerf.default 711 704 1.01:1
MenuButtonMinimalPerf.default 1526 1510 1.01:1
PopupMinimalPerf.default 551 544 1.01:1
SplitButtonMinimalPerf.default 3569 3550 1.01:1
StatusMinimalPerf.default 646 639 1.01:1
CustomToolbarPrototype.default 3672 3648 1.01:1
TreeMinimalPerf.default 748 744 1.01:1
VideoMinimalPerf.default 578 573 1.01:1
AttachmentMinimalPerf.default 143 143 1:1
ChatDuplicateMessagesPerf.default 274 274 1:1
CheckboxMinimalPerf.default 2603 2606 1:1
DialogMinimalPerf.default 702 702 1:1
InputMinimalPerf.default 1204 1200 1:1
ProviderMinimalPerf.default 950 946 1:1
RefMinimalPerf.default 221 220 1:1
SegmentMinimalPerf.default 324 324 1:1
TreeWith60ListItems.default 152 152 1:1
AttachmentSlotsPerf.default 1006 1018 0.99:1
ButtonSlotsPerf.default 513 520 0.99:1
DividerMinimalPerf.default 342 346 0.99:1
ItemLayoutMinimalPerf.default 1114 1124 0.99:1
LoaderMinimalPerf.default 659 665 0.99:1
SliderMinimalPerf.default 1492 1511 0.99:1
TableMinimalPerf.default 378 382 0.99:1
TooltipMinimalPerf.default 948 960 0.99:1
AlertMinimalPerf.default 251 256 0.98:1
CardMinimalPerf.default 511 524 0.98:1
DropdownMinimalPerf.default 2961 3024 0.98:1
GridMinimalPerf.default 313 318 0.98:1
LabelMinimalPerf.default 356 366 0.97:1
LayoutMinimalPerf.default 334 344 0.97:1
RosterPerf.default 1086 1115 0.97:1
BoxMinimalPerf.default 323 338 0.96:1
HeaderMinimalPerf.default 328 340 0.96:1
ListMinimalPerf.default 463 484 0.96:1
TextAreaMinimalPerf.default 463 481 0.96:1
ListCommonPerf.default 573 623 0.92:1

@tringakrasniqi tringakrasniqi marked this pull request as ready for review July 16, 2021 16:26
@tringakrasniqi tringakrasniqi requested review from behowell and a team as code owners July 16, 2021 16:26
@tringakrasniqi tringakrasniqi mentioned this pull request Jul 16, 2021
Closed
32 tasks
behowell
behowell approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@behowell behowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating react-tooltip!
FYI, I have a PR out for Tooltip that'll have merge conflicts with this PR: #18610. Chances are your PR will be merged before mine, so I'll handle resolving the merge conflict. But just wanted to let you know in case mine goes in first.

@layershifter layershifter mentioned this pull request Jul 20, 2021
Merged
2 tasks
@Hotell
Copy link
Contributor

Hotell commented Jul 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Hotell Hotell mentioned this pull request Jul 20, 2021
Merged
@Hotell
Copy link
Contributor

Hotell commented Jul 20, 2021

CI is failing - fix PR #19021

@tringakrasniqi tringakrasniqi merged commit e2360de into microsoft:master Jul 21, 2021
@tringakrasniqi tringakrasniqi deleted the dx-migration-tooltip branch July 21, 2021 09:39
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
@tringakrasniqi @PeterDraex
react-tooltip: Migration to new DX (microsoft#18977)
bfb3543 
* react-tooltip migration to new DX

* Added change files for tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@behowell behowell behowell approved these changes

Assignees

@ling1726 ling1726

Labels
Area: Build System Component: Tooltip
Projects
None yet
Milestone
July Project Cycle Q3 2021
Development

Successfully merging this pull request may close these issues.
5 participants
@tringakrasniqi @fabricteam @Hotell @behowell @ling1726