Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yaaredis): remove yaaredis support #12226

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Feb 5, 2025

yaaredis is deprecated, we shouldn't support it

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Feb 5, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/remove-yaaredis-095441532392e12f.yaml                @DataDog/apm-python
ddtrace/_monkey.py                                                      @DataDog/apm-core-python
docs/index.rst                                                          @DataDog/python-guild
docs/integrations.rst                                                   @DataDog/python-guild
docs/spelling_wordlist.txt                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
supported_versions_output.json                                          @DataDog/apm-core-python
supported_versions_table.csv                                            @DataDog/apm-core-python
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Benchmark execution time: 2025-02-06 21:40:59

Comparing candidate commit 1eb7cc4 in PR branch munir/remove-unwanted-warnings with baseline commit 1247ac2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur changed the base branch from main to 3.x-staging February 5, 2025 22:05
@mabdinur mabdinur requested review from a team as code owners February 5, 2025 22:05
@mabdinur mabdinur changed the base branch from 3.x-staging to main February 5, 2025 22:06
@mabdinur mabdinur enabled auto-merge (squash) February 5, 2025 22:06
Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed since 025c020?

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 6, 2025

Datadog Report

Branch report: munir/remove-unwanted-warnings
Commit report: 1eb7cc4
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 35.01s Total duration (25m 19.78s time saved)

@mabdinur
Copy link
Contributor Author

mabdinur commented Feb 6, 2025

What changed since 025c020?

Ahhh I missed this. I just went off the deprecation warning. I'll remove the whole integration.

@mabdinur mabdinur changed the title chore(yaaredis): remove unwanted deprecation warning chore(yaaredis): remove yaaredis support Feb 6, 2025
@mabdinur mabdinur closed this Feb 6, 2025
auto-merge was automatically disabled February 6, 2025 18:17

Pull request was closed

@mabdinur mabdinur reopened this Feb 6, 2025
@mabdinur mabdinur force-pushed the munir/remove-unwanted-warnings branch from a0b8c83 to f48a9fd Compare February 6, 2025 20:40
@mabdinur mabdinur changed the base branch from main to 3.x-staging February 6, 2025 20:40
@mabdinur mabdinur changed the base branch from 3.x-staging to main February 6, 2025 20:41
@erikayasuda erikayasuda requested review from a team as code owners February 6, 2025 20:43
@mabdinur mabdinur force-pushed the munir/remove-unwanted-warnings branch from f48a9fd to 1eb7cc4 Compare February 6, 2025 20:53
@mabdinur mabdinur enabled auto-merge (squash) February 6, 2025 21:41
@mabdinur mabdinur merged commit 6a06f77 into main Feb 7, 2025
678 of 679 checks passed
@mabdinur mabdinur deleted the munir/remove-unwanted-warnings branch February 7, 2025 11:54
gnufede pushed a commit that referenced this pull request Feb 19, 2025
With `ddtrace>=3.0` the implementation details of the yaaredis
integration is internal to the tracer. We can remove this integration
without introducing a breaking change.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Copy link
Contributor

The backport to 2.21 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-12226-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a06f77b338ee3929cf3bbc9237fe76175e0a001
# Push it to GitHub
git push --set-upstream origin backport-12226-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21

Then, create a pull request where the base branch is 2.21 and the compare/head branch is backport-12226-to-2.21.

github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
With `ddtrace>=3.0` the implementation details of the yaaredis
integration is internal to the tracer. We can remove this integration
without introducing a breaking change.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 6a06f77)
@erikayasuda
Copy link
Contributor

Note to future self: We are going to revert this from main since it unfortunately missed getting backported to 3.0 during the 2.x -> 3.x migration. It's already behind a deprecation flag, so it should be removed completely in 4.0 when we do the 3.x -> 4.x migration next year.

erikayasuda added a commit that referenced this pull request Feb 21, 2025
erikayasuda added a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants