-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(yaaredis): remove yaaredis support #12226
Conversation
|
BenchmarksBenchmark execution time: 2025-02-06 21:40:59 Comparing candidate commit 1eb7cc4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
releasenotes/notes/remove-unwanted-warnings-yaaredis-5526961fbda69e8a.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed since 025c020?
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 35.01s Total duration (25m 19.78s time saved) |
Ahhh I missed this. I just went off the deprecation warning. I'll remove the whole integration. |
Pull request was closed
a0b8c83
to
f48a9fd
Compare
f48a9fd
to
1eb7cc4
Compare
With
ddtrace>=3.0
the implementation details of the yaaredis integration is internal to the tracer. We can remove this integration without introducing a breaking change.Checklist
Reviewer Checklist