Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yaaredis): remove yaaredis support [backport 2.21] #12478

Closed
wants to merge 2 commits into from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Feb 21, 2025

Backport 6a06f77 from #12226 to 2.21.

With ddtrace>=3.0 the implementation details of the yaaredis integration is internal to the tracer. We can remove this integration without introducing a breaking change.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda changed the base branch from main to 2.21 February 21, 2025 17:49
@erikayasuda erikayasuda changed the title chore(yaaredis): remove yaaredis support [backport 3.0] chore(yaaredis): remove yaaredis support [backport 2.21] Feb 21, 2025
@erikayasuda erikayasuda reopened this Feb 21, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/remove-yaaredis-095441532392e12f.yaml                @DataDog/apm-python
ddtrace/_monkey.py                                                      @DataDog/apm-core-python
docs/index.rst                                                          @DataDog/python-guild
docs/integrations.rst                                                   @DataDog/python-guild
docs/spelling_wordlist.txt                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
supported_versions_output.json                                          @DataDog/apm-core-python
supported_versions_table.csv                                            @DataDog/apm-core-python
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

@erikayasuda erikayasuda marked this pull request as ready for review February 21, 2025 17:50
@erikayasuda erikayasuda requested review from a team as code owners February 21, 2025 17:50
@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-21 18:29:55

Comparing candidate commit e24616b in PR branch backport-12226-to-2.21 with baseline commit 749133b in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@erikayasuda erikayasuda deleted the backport-12226-to-2.21 branch April 3, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants