Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(yaaredis): remove yaaredis support" #12480

Merged
merged 7 commits into from
Feb 24, 2025

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Feb 21, 2025

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@erikayasuda erikayasuda requested review from a team as code owners February 21, 2025 18:41
Copy link
Contributor

github-actions bot commented Feb 21, 2025

CODEOWNERS have been resolved as:

.riot/requirements/1761702.txt                                          @DataDog/apm-python
.riot/requirements/1cc7b0e.txt                                          @DataDog/apm-python
.riot/requirements/1f1e9b4.txt                                          @DataDog/apm-python
.riot/requirements/9b8251b.txt                                          @DataDog/apm-python
.riot/requirements/fda8aa6.txt                                          @DataDog/apm-python
ddtrace/contrib/_yaaredis.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/yaaredis/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/yaaredis/__init__.py                                      @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/yaaredis/test_yaaredis.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/yaaredis/test_yaaredis_patch.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_analytics_with_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_analytics_without_rate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_basics.json   @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_cmd_max_length.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_full_command_in_resource_config[True].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_full_command_in_resource_env.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_long_command.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_opentracing.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_pipeline_immediate.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_pipeline_traced.json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_schematization[service_schema0].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_schematization[service_schema1].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_schematization[service_schema2].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_schematization[service_schema3].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_schematization[service_schema4].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_schematization[service_schema5].json  @DataDog/apm-python
tests/snapshots/tests.contrib.yaaredis.test_yaaredis.test_unicode.json  @DataDog/apm-python
ddtrace/_monkey.py                                                      @DataDog/apm-core-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
docs/index.rst                                                          @DataDog/python-guild
docs/integrations.rst                                                   @DataDog/python-guild
docs/spelling_wordlist.txt                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
supported_versions_output.json                                          @DataDog/apm-core-python
supported_versions_table.csv                                            @DataDog/apm-core-python
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python

@erikayasuda erikayasuda enabled auto-merge (squash) February 21, 2025 18:42
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 21, 2025

Datadog Report

Branch report: revert-12226-munir/remove-unwanted-warnings
Commit report: ab8122e
Test service: dd-trace-py

✅ 0 Failed, 43 Passed, 460 Skipped, 46.13s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-24 18:27:12

Comparing candidate commit ab8122e in PR branch revert-12226-munir/remove-unwanted-warnings with baseline commit 96b4a11 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@erikayasuda erikayasuda merged commit 5434666 into main Feb 24, 2025
777 of 779 checks passed
@erikayasuda erikayasuda deleted the revert-12226-munir/remove-unwanted-warnings branch February 24, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants