Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ssh-keys command #873

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add ssh-keys command #873

wants to merge 3 commits into from

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Jan 25, 2025

This PR adds a ssh-keys command, to add, remove(-all), list SSH keys from a user account and to open the SSH Keys panel from the Console.

If no SSH keys are found, instructions to create one are printed.

I've added 2 utils.js functions in a dedicaeted commit:

  • To execute a function and just print the result if it succeed, an error if it fails. I got lots of redundant code in SSH Keys/Emails management because of that.
  • To open a web page with a message (as we do it from multiple parts of the code, we can reuse it later). It's also used in the emails command PR

@davlgd davlgd self-assigned this Jan 25, 2025
@davlgd davlgd requested a review from a team as a code owner January 25, 2025 14:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

🔎 A preview has been automatically published:

  • 🐧 linux a8601f8eef6a73078b8ee08c130530b8e67a9d513fe3deb96eeab715d5d2a416
  • 🍏 macos 92fed8a6b7c81fba6c774126ef98b1215ec133a7a165df47dc045f6b906d1723
  • 🪟 win 065f15d66dec01e7c1e9279421679edde5466650142f123e25594f64e5c778a6

This preview will be deleted once this PR is closed.

@davlgd davlgd mentioned this pull request Jan 25, 2025
Open
@davlgd davlgd added this to the 3.13 milestone Jan 25, 2025
pdesoyres-cc
pdesoyres-cc requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this works fine. I've got few suggestions and minor improvements.

@davlgd davlgd requested a review from pdesoyres-cc January 30, 2025 17:24
@davlgd davlgd force-pushed the davlgd-ssh-keys branch from f9e4d12 to f5a86b8 Compare March 6, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdesoyres-cc pdesoyres-cc pdesoyres-cc approved these changes

Assignees

@davlgd davlgd

Labels
None yet
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
2 participants
@davlgd @pdesoyres-cc