fix: after Pierre's review

CleverCloud · Jan 30, 2025 · 2dee3a2 · 2dee3a2
1 parent fbf9bf5
commit 2dee3a2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 16 deletions.
diff --git a/src/commands/env.js b/src/commands/env.js
@@ -8,7 +8,6 @@ import * as application from '@clevercloud/client/esm/api/v2/application.js';
 
 export async function list (params) {
   const { alias, app: appIdOrName, 'add-export': addExportsOption, format } = params.options;
-  console.log(params.options);
   const { ownerId, appId } = await Application.resolveId(appIdOrName, alias);
   const [envFromApp, envFromAddons, envFromDeps] = await Promise.all([
     application.getAllEnvVars({ id: ownerId, appId }).then(sendToApi),

diff --git a/src/commands/ssh-keys.js b/src/commands/ssh-keys.js
@@ -35,8 +35,7 @@ export async function add (params) {
   const { 'ssh-key-name': keyName, 'ssh-key-path': filePath } = params.namedArgs;
 
   if (!existsSync(filePath)) {
-    Logger.error(`File ${filePath} does not exist`);
-    return;
+    throw new Error(`File ${filePath} does not exist`);
   }
 
   const fileContent = readFileSync(filePath, 'utf8').trim();
@@ -50,7 +49,7 @@ export async function add (params) {
  */
 export async function remove (params) {
   const { 'ssh-key-name': keyName } = params.namedArgs;
-  executeCommand(removeKey, [keyName]);
+  await executeCommand(removeKey, [keyName]);
 }
 
 /**
@@ -95,20 +94,20 @@ function printKeysHuman (keys) {
   }
 
   if (keys.length === 1) {
-    Logger.println(`🔐 Current user have 1 SSH key: ${keys[0].name} (${keys[0].fingerprint})`);
+    Logger.println(`🔐 Current user has 1 SSH key: ${keys[0].name} (${keys[0].fingerprint})`);
     return;
   }
 
-  Logger.println(`🔐 Current user have ${keys.length} SSH keys:`);
+  Logger.println(`🔐 Current user has ${keys.length} SSH keys:`);
   keys.forEach((k) => {
-    Logger.println(` ▶ ${colors.blue(k.name)}`, colors.grey(`(${k.fingerprint})`));
+    Logger.println(` • ${colors.blue(k.name)}`, colors.grey(`(${k.fingerprint})`));
   });
 }
 
 /**
  * Open the SSH keys management page of the Console in your browser
  * @returns {Promise<void>} A promise that resolves when the page is opened
  */
-export async function openConsole () {
-  openBrowser('https://console.clever-cloud.com/users/me/ssh-keys', 'Opening the SSH keys management page in your browser');
+export function openConsole () {
+  return openBrowser('https://console.clever-cloud.com/users/me/ssh-keys', 'Opening the SSH keys management page in your browser');
 }
diff --git a/src/models/utils.js b/src/models/utils.js
@@ -24,13 +24,8 @@ export class Deferred {
  * @throws {Error} If the command execution fails
  */
 export async function executeCommand (fn, params) {
-  try {
-    const result = await fn(...params);
-    Logger.println(result.message);
-  }
-  catch (e) {
-    Logger.error(e.message);
-  }
+  const result = await fn(...params);
+  Logger.println(result.message);
 }
 
 /**