-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add emails command #874
base: master
Are you sure you want to change the base?
Conversation
🔎 A preview has been automatically published:
This preview will be deleted once this PR is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done David. I have several comments and some fixes to apply (some of them are due to API limitations or bugs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Well done @davlgd
13cf2e5
to
6610dc9
Compare
@@ -69,6 +69,17 @@ export function futureDateOrDuration (dateString) { | |||
return duration; | |||
} | |||
|
|||
// Could be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could or should?
This PR adds an
emails
commands to add, remove(-all) secondary emails to a user account, set the primary email, list emails, and open the emails management page in the Console.I've added an email parser to validate emails. It uses a simple regex to avoid corner cases. There is another proposition in comment, chose the one you prefer.
This PR includes and uses the 2
utils.js
functions introduced in #873