Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emails command #874

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add emails command #874

wants to merge 4 commits into from

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Jan 25, 2025

This PR adds an emails commands to add, remove(-all) secondary emails to a user account, set the primary email, list emails, and open the emails management page in the Console.

I've added an email parser to validate emails. It uses a simple regex to avoid corner cases. There is another proposition in comment, chose the one you prefer.

This PR includes and uses the 2 utils.js functions introduced in #873

@davlgd davlgd added this to the 3.13 milestone Jan 25, 2025
@davlgd davlgd self-assigned this Jan 25, 2025
@davlgd davlgd requested a review from a team as a code owner January 25, 2025 14:45
Copy link

github-actions bot commented Jan 25, 2025

🔎 A preview has been automatically published:

  • 🐧 linux e6630719d93f90ded93136327c31594703257da2a9cccff03d2ed7cbd0116709
  • 🍏 macos f9e98dd874c6ec77ece1c4b6083e8ef88ec2bae9b89000a6b9909fad5d1bc933
  • 🪟 win c77f1fe29ca38471b52f7afc547a711e08ebb81e247566700c6df5a1c1bdf0db

This preview will be deleted once this PR is closed.

Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done David. I have several comments and some fixes to apply (some of them are due to API limitations or bugs).

Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done @davlgd

@davlgd davlgd force-pushed the davlgd-better-profile branch from 13cf2e5 to 6610dc9 Compare March 6, 2025 20:50
@@ -69,6 +69,17 @@ export function futureDateOrDuration (dateString) {
return duration;
}

// Could be:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could or should?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants