std.c: more fixes #22654
Open
std.c: more fixes #22654
+24
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
Jan 29, 2025
| @@ -4817,7 +4817,7 @@ pub const AccessError = error{ | |||
| /// | |||
| /// On Windows, `mode` is ignored. This is a POSIX API that is only partially supported by | |||
| /// Windows. See `fs` for the cross-platform file system API. | |||
| pub fn access(path: []const u8, mode: u32) AccessError!void { | |||
| pub fn access(path: []const u8, mode: c_int) AccessError!void { | |||
There was a problem hiding this comment.
Andrew prefers to keep c_int (& co) usage limited to std.c. It's unclear to me where that leaves std.posix, considering POSIX is an extension of C. cc @andrewrk
There was a problem hiding this comment.
Please try to think of "std.posix" as a concept that is what it needs to be rather than being defined by some third party group. Everyone gets hung up on this, so I think it will have to be renamed yet again.
POSIX is irrelevant. C is irrelevant. This is an abstraction layer
There was a problem hiding this comment.
So just to be completely clear: no c_int, yeah?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regressions found during oven-sh/bun#16862