-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zig: update to 0.14.0-dev #16862
zig: update to 0.14.0-dev #16862
Conversation
Updated 1:03 AM PT - Feb 1st, 2025
❌ @nektro, your commit 4e840f7 has 1 failures in
🧪 try this PR locally: bunx bun-pr 16862 |
@@ -524,63 +524,54 @@ pub const AspectRatio = struct { | |||
}; | |||
|
|||
pub const BackgroundProperty = packed struct(u16) { | |||
@"background-color": bool = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's clearer to keep it as the exact CSS property name. Instead of having to mentally ask "is it background-color or is it color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i presumed that was clear since it was on BackgroundProperty
and i needed the fields to not interfere with the decl shorthands which are used heavily and do match the name of the respective property
after looking through them, i suspect most can be removed without additional changes. some need to change related atomic accesses (see ziglang/zig#21585) |
these functions used to not be analyzed in 0.13 and now they are so skipping them shouldnt break anything
updates bun to use Zig 0.14.0-dev.2987+183bb8b08
PR'd upstream (non-blocking):
Issues filed upstream (non-blocking):
type 'T' has no members
error has no 'defined here' notes ziglang/zig#22666cannot represent integer value
error should have a 'defined here' note when its a parameter ziglang/zig#22670