PDE-5774 fix(core): Catch HTTP 500 along with status codes >500 in RPC client #974
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohh, 500 is a valid HTTP response for legacy reasons. I forgot! |
rnegron
changed the base branch from
main
to
zapier-platform-major-release-17.0.0-dev
rnegron
changed the base branch from
zapier-platform-major-release-17.0.0-dev
to
main
rnegron
changed the base branch from
main
to
zapier-platform-major-release-17.0.0-dev
|
Following this PR, we should keep the retry logic for 5xx errors. |
rnegron
commented
Feb 20, 2025
| @@ -108,7 +108,7 @@ const createRpcClient = (event) => { | |||
| try { | |||
| res = await request(req); | |||
|
|
|||
| if (res.status > 500) { | |||
| if (res.status >= 500) { | |||
There was a problem hiding this comment.
HTTP 500 is now a non-standard response code (note this PR is targeting a major release branch as this could be a breaking change)
rnegron
commented
Feb 20, 2025
| @@ -51,10 +51,10 @@ const mockRpcGetPresignedPostCall = (key) => { | |||
| }); | |||
| }; | |||
|
|
|||
| const mockRpcFail = (error) => { | |||
| const mockRpcFail = (error, status = 400) => { | |||
There was a problem hiding this comment.
HTTP 400 is the default error code for manual failures in the RPC API now, so I've set it as the default for this test
rnegron
commented
Feb 20, 2025
| mocky.mockRpcFail('this is an expected explosion'); | ||
| mocky.mockRpcFail('this is an expected explosion'); | ||
| mocky.mockRpcFail('this is an expected explosion'); | ||
| mocky.mockRpcFail('this is an expected explosion', 500); |
There was a problem hiding this comment.
The explode RPC method actually throws an HTTP 500 via an exception being raised 😅
rnegron
merged commit 051bfff
into
zapier-platform-major-release-17.0.0-dev
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see
Got id undefined but expected ID_NUMBER when calling RPCerrors when it comes to RPC endpoints returning a 500 response. Inspecting the code, I believe we should likely catch the error before we checkres.content.id.After this change is released, we should update our log stream alarms to ALSO consider the
Unable to reach the RPC servertext instead of just theGot id ${res.content.id} but expected ${id} when calling RPCtext. Both texts should be viable since we could have apps still running on previous versions.