PDE-5774 fix(core): Catch HTTP 500 along with status codes >500 in RP…

…C client (#974)

* HTTP 500 is no longer expected

* fix test

* update test logic

packages/core/src/tools/create-rpc-client.js

@@ -108,7 +108,7 @@ const createRpcClient = (event) => {
       try {
         res = await request(req);
 
-        if (res.status > 500) {
+        if (res.status >= 500) {
           throw new Error('Unable to reach the RPC server');
         }
         if (res.content) {

packages/core/test/tools/mocky.js

@@ -51,10 +51,10 @@ const mockRpcGetPresignedPostCall = (key) => {
     });
 };
 
-const mockRpcFail = (error) => {
+const mockRpcFail = (error, status = 400) => {
   nock(FAKE_ZAPIER_URL)
     .post(RPC_URL_PATH)
-    .reply(500, (uri, requestBody) => {
+    .reply(status, (uri, requestBody) => {
       const id = JSON.parse(requestBody).id;
       return { error, id };
     });

packages/core/test/tools/rpc-client.js

@@ -16,17 +16,17 @@ describe('rpc client', () => {
 
   it('should handle an explosion', () => {
     // mock 3 explosions due to retry
-    mocky.mockRpcFail('this is an expected explosion');
-    mocky.mockRpcFail('this is an expected explosion');
-    mocky.mockRpcFail('this is an expected explosion');
+    mocky.mockRpcFail('this is an expected explosion', 500);
+    mocky.mockRpcFail('this is an expected explosion', 500);
+    mocky.mockRpcFail('this is an expected explosion', 500);
 
     return rpc('explode')
       .then(() => {
         throw new Error('this should have exploded');
       })
       .catch((err) => {
         err.message.should.eql(
-          'RPC request failed after 3 attempts: this is an expected explosion',
+          'RPC request failed after 3 attempts: Unable to reach the RPC server',
         );
       });
   });