Skip to content

Spelling #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2018
Merged

Spelling #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
429eebb
spelling: becomes
jsoref Feb 25, 2018
fc37303
spelling: elapsed
jsoref Feb 25, 2018
1e16981
spelling: yay
jsoref Feb 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ async function fetchPackage({name, reference}) {
export async function getPinnedReference({name, reference}) {

// 1.0.0 is a valid range per semver syntax, but since it's also a pinned
// reference, we don't actually need to process it. Less work, yeay!~
// reference, we don't actually need to process it. Less work, yay!~
if (semver.validRange(reference) && !semver.valid(reference)) {

let response = await fetch(`https://registry.yarnpkg.com/${name}`);
Expand Down Expand Up @@ -219,7 +219,7 @@ function optimizePackageTree({name, reference, dependencies}) {

// If we've adopted the sub-dependency, or if the already existing
// dependency has the exact same reference than the sub-dependency,
// then it becames useless and we can simply delete it.
// then it becomes useless and we can simply delete it.
if (!availableDependency || availableDependency.name === subDependency.name) {
hardDependency.dependencies.splice(hardDependency.dependencies.findIndex(dependency => {
return dependency.name === subDependency.name;
Expand Down
2 changes: 1 addition & 1 deletion utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export async function extractNpmArchiveTo(packageBuffer, target) {

export async function trackProgress(cb) {

let pace = new Progress(`:bar :current/:total (:elapseds)`, {width: 80, total: 1});
let pace = new Progress(`:bar :current/:total (:elapsed)`, {width: 80, total: 1});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that :elapseds is a real thing, if so, I'll happily file a bug against whichever group is using it, because that's awful.


try {

Expand Down