Spelling

[jsoref]

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

[jsoref]

It's possible that :elapseds is a real thing, if so, I'll happily file a bug against whichever group is using it, because that's awful.

[bestander]

Thanks!

[arcanis]

It was not a typo, the trailing 's' is just left as is - :elapseds gives "42s", whereas :elapsed gives "42" (unitless).

…

On Sun, Feb 25, 2018, 6:55 PM Konstantin Raev ***@***.***> wrote: Merged #3 <#3>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_Wa_9N9lBUidBnc59FGb_bR_OK9Cblks5tYZ6NgaJpZM4SSWt1> .

[bestander]

Oh snap, trigger happy finger. Let’s revert On Sun, Feb 25, 2018 at 10:56 AM Maël Nison <[email protected]> wrote:

…

It was not a typo, the trailing 's' is just left as is - :elapseds gives "42s", whereas :elapsed gives "42" (unitless). On Sun, Feb 25, 2018, 6:55 PM Konstantin Raev ***@***.***> wrote: > Merged #3 <#3>. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#3 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AA_Wa_9N9lBUidBnc59FGb_bR_OK9Cblks5tYZ6NgaJpZM4SSWt1 > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWAnVj1j0cFJiKLXMQYEmmFEo3tpHks5tYazZgaJpZM4SSWt1> .

[bestander]

Fixed back f02ab07

[jsoref]

Sorry about that...
Is there no ${elapsed}s like notation that avoids such ambiguities?

[arcanis]

None that I'm aware of - the progress module makes a simple replacement. We could have `${`:elapsed`}s`, but it's only marginally more readable.

[jsoref]

Thanks, I just looked. I'd personally suggest asking them to offer something for this.
If I manage to trigger "1000s" or "10000s", reading that would be awful.
It would make sense for the system to support magical unit insertion.
A readable fix would be :elapsed s or :elapsed secs.

Anyway, thanks for working on this project and spending the time to look into that one. Sorry for distracting you from bigger things.