Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added irish ga #501

Merged
merged 2 commits into from
Feb 8, 2025
Merged

added irish ga #501

merged 2 commits into from
Feb 8, 2025

Conversation

aindriu80
Copy link

@aindriu80 aindriu80 commented Feb 3, 2025

Description

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Update

I added the 3 missing files, I copied them from other languages and changed to match Irish.

@romanvm
Copy link
Collaborator

romanvm commented Feb 3, 2025

Please recreate whole language addon structure, not just strings.po. Use other language addons as examples.

@gade01
Copy link

gade01 commented Feb 3, 2025

It's a huge task creating a new language.
Everything needs to be properly set up at Github.
Everything needs to be created at Weblate as well. Language teams need to be created and we should make sure to have enough translators to maintain the language for core and all addons.

@aindriu80
Copy link
Author

It's a huge task creating a new language.
Everything needs to be properly set up at Github.
Everything needs to be created at Weblate as well. Language teams need to be created and we should make sure to have enough translators to maintain the language for core and all addons.

Yes, creating a new language is indeed a significant undertaking, Kodi is huge. I'm happy to support this effort and help with setting up the Irish language on GitHub and Weblate, as well as coordinating translator teams. Other large projects such as Nextcloud have been fully translated into Irish.

@basilgello
Copy link

@phunkyfish you might also be interested

@romanvm
Copy link
Collaborator

romanvm commented Feb 4, 2025

@gade01 Could you document main aspscts of language management in Kodi/Weblate? Because I have to use trial/error approach. Will adding a lauguage addon here be enough to be synced back to Weblate? As for language teams on Weblate, it seems that our instance has Irish language support.

@aindriu80
Copy link
Author

I wanted to follow up regarding this PR for adding the Irish language to Kodi. The pull request includes 4 files that I’ve adapted from other languages, and I’ve ensured that the files align with the required structure for Kodi’s language support

It seems like the issue lies more in Kodi's internal handling rather than Weblate. https://github.com/WeblateOrg/weblate/pull/13739/files Shows a conditional check in the code, which prevents adding new languages if the component isn't configured to allow it. While this commit helps clarify the reasoning, the core issue may require configuring the component properly for Irish language support. This PR may help in unlocking the current block.

Regarding the failing check - It seems the issue is related to a missing module (lib2to3), which is no longer included by default in Python 3.13. To resolve this issue you could try installing the module via pip install lib2to3 , however you may need to ensure the add-on checker is fully compatible with Python 3. Perhaps you could update the checker script to handle Python 3 better.

I understand that adding new languages in Kodi is a significant task, but I believe that Irish language support is an important step forward. Please let me know if there’s anything further needed on my end to move the PR forward.

Thank you for your consideration!

@romanvm
Copy link
Collaborator

romanvm commented Feb 8, 2025

Ok, addon structure seems to be correct. I'm merging this into the repo and let's see what happens.

@romanvm romanvm merged commit 8b03b30 into xbmc:omega Feb 8, 2025
1 check failed
@aindriu80
Copy link
Author

Ok, addon structure seems to be correct. I'm merging this into the repo and let's see what happens.

That's great thanks, hopefully it unblocks it.

@aindriu80 aindriu80 mentioned this pull request Feb 11, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants