-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added irish ga #501
added irish ga #501
Conversation
Please recreate whole language addon structure, not just strings.po. Use other language addons as examples. |
It's a huge task creating a new language. |
Yes, creating a new language is indeed a significant undertaking, Kodi is huge. I'm happy to support this effort and help with setting up the Irish language on GitHub and Weblate, as well as coordinating translator teams. Other large projects such as Nextcloud have been fully translated into Irish. |
@phunkyfish you might also be interested |
@gade01 Could you document main aspscts of language management in Kodi/Weblate? Because I have to use trial/error approach. Will adding a lauguage addon here be enough to be synced back to Weblate? As for language teams on Weblate, it seems that our instance has Irish language support. |
I wanted to follow up regarding this PR for adding the Irish language to Kodi. The pull request includes 4 files that I’ve adapted from other languages, and I’ve ensured that the files align with the required structure for Kodi’s language support It seems like the issue lies more in Kodi's internal handling rather than Weblate. https://github.com/WeblateOrg/weblate/pull/13739/files Shows a conditional check in the code, which prevents adding new languages if the component isn't configured to allow it. While this commit helps clarify the reasoning, the core issue may require configuring the component properly for Irish language support. This PR may help in unlocking the current block. Regarding the failing check - It seems the issue is related to a missing module ( I understand that adding new languages in Kodi is a significant task, but I believe that Irish language support is an important step forward. Please let me know if there’s anything further needed on my end to move the PR forward. Thank you for your consideration! |
Ok, addon structure seems to be correct. I'm merging this into the repo and let's see what happens. |
That's great thanks, hopefully it unblocks it. |
Description
Checklist:
Additional information :
Update
I added the 3 missing files, I copied them from other languages and changed to match Irish.