Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed locale from ie-ga to ga-ie #515

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Changed locale from ie-ga to ga-ie #515

merged 1 commit into from
Feb 11, 2025

Conversation

aindriu80
Copy link

Description

This PR fixes an locale mistake - original locale had ie-ga instead of ga_IE. 4 files which were uploaded in #501 have been renamed

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Screenshot showing existing ie-ga which comes up Occidental (ie_GA) - unrecognised locale.

2025-02-11_14-15

@aindriu80
Copy link
Author

@romanvm In my previous Pull Request, I got the locale format wrong. I had it named as "ie_GA" instead of "ga_IE". This PR fixes that mistake.

I checked on Weblate Kodi and see the 'Occidental (ie_GA)' dated Feb. 8, 2025, 8:36 a.m. appeared, Weblate doesn't recognise ie_GA and seems to have given the title Occidental to it.

@romanvm
Copy link
Collaborator

romanvm commented Feb 11, 2025

Thanks.

@romanvm romanvm merged commit f4b0af8 into xbmc:omega Feb 11, 2025
1 check failed
@aindriu80
Copy link
Author

Thanks.

Thank you! It looks fixed now :)

2025-02-11_18-14

@romanvm
Copy link
Collaborator

romanvm commented Feb 12, 2025

I also added a language definision for ga_ie language code on the Weblate side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants