Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destinationPath option #7

Closed
wants to merge 2 commits into from
Closed

Add destinationPath option #7

wants to merge 2 commits into from

Conversation

drag0s
Copy link

@drag0s drag0s commented May 2, 2019

If this option is specified, it would allow a user to choose video's destination path. Else, destination path would still be the path generated by tempy.

@skllcrn skllcrn requested a review from sindresorhus May 2, 2019 23:38
@sindresorhus sindresorhus changed the title Add destinationPath option Add destinationPath option Jun 14, 2019
@sindresorhus
Copy link
Contributor

What's your use-case for this?

Default: A `.mp4` file in a temporary directory

Destination file path for the video.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that it's better to not set this and rather move the file when the export is done, so users don't see a incomplete file during recording.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or set this to a temp directory on a different disk if it's set for space reasons.

@timwedde
Copy link

I know this PR is already a bit older however I, too, would be interested in this addition.
I can't speak for anyone else of course but my personal use case for this is relatively simple: My main drive is quite small and already occupied by other vital stuff. Not being able to change where the original recording saves to is a major hindrance when you only have very little space left.
Meanwhile I have an entirely unused 1TB SSD mounted anyway, which I could record to without a problem if this were implemented.

@sindresorhus
Copy link
Contributor

Closing for lack of response. Someone else can continue it if they need it: #9

@alectrocute
Copy link

Continued in #11. I argue the use case of moving a file once it's done may be trouble – like @timwedde mentioned, if the temporary folder isn't an option for whatever reason, drive space etc., then it may be best to allow the user to explicitly set the processing/final location.

@alectrocute
Copy link

For my specific use case, I'm saving the file externally, so this makes sense. @sindresorhus, thoughts?

@sindresorhus
Copy link
Contributor

I'm fine with adding this, but the docs should mention the different use-cases for the option.

@alectrocute
Copy link

I'm fine with adding this, but the docs should mention the different use-cases for the option.

Great! I'll append, squash and prepare this.

@sindresorhus sindresorhus mentioned this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants