-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add destinationPath
option
#7
Conversation
What's your use-case for this? |
Default: A `.mp4` file in a temporary directory | ||
|
||
Destination file path for the video. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted that it's better to not set this and rather move the file when the export is done, so users don't see a incomplete file during recording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or set this to a temp directory on a different disk if it's set for space reasons.
I know this PR is already a bit older however I, too, would be interested in this addition. |
Closing for lack of response. Someone else can continue it if they need it: #9 |
For my specific use case, I'm saving the file externally, so this makes sense. @sindresorhus, thoughts? |
I'm fine with adding this, but the docs should mention the different use-cases for the option. |
Great! I'll append, squash and prepare this. |
If this option is specified, it would allow a user to choose video's destination path. Else, destination path would still be the path generated by tempy.