Add destinationPath option to .startRecording()
#11
Conversation
sindresorhus
changed the title
destination option string to .startRecording()destination option to .startRecording()
alectrocute
changed the title
destination option to .startRecording()destinationPath option to .startRecording()
|
Hi @sindresorhus, I've added the relevant documentation. Would you like me to go a bit more in-depth? Cheers! |
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Don't do unrelated changes.
| @@ -32,7 +33,7 @@ const options = { | |||
| await aperture.startRecording(options); | |||
| await delay(3000); | |||
| console.log(await aperture.stopRecording()); | |||
| //=> '/private/var/folders/3x/jf5977fn79jbglr7rk0tq4d00000gn/T/cdf4f7df426c97880f8c10a1600879f7.mp4' | |||
| //=> '/private/var/folders/3x/jf5977fn79j/T/cdf4f7df426c97880f8c10a1600879f7.mp4' | |||
There was a problem hiding this comment.
Don't do unrelated changes.
|
The docs should describe why it's beneficial not to use this option, as described in #7 (comment) |
|
@alectrocute Do we know what exactly is missing here? I am not very used to working on pull requests and will have to learn the process but I am interested in this Pull Request being picked up again and finished. Specifically for the use case of storing the temp file on an external NVME SSD to have more storage for ProRes recording. I'm willing to help but as mentioned, I don't know Pull Request processes that well 🙈. |
Fixes #9