Add support for second I2C port #7878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: wpilibj
PeterJohnson
requested changes
Mar 21, 2025
PeterJohnson
requested changes
Mar 21, 2025
| constexpr const char* physicalPorts[] = {"/dev/i2c-1", "/dev/i2c-10"}; | ||
|
|
||
| struct I2C { | ||
| std::mutex initMutex; |
There was a problem hiding this comment.
Suggested change
| std::mutex initMutex; | |
| wpi::mutex initMutex; |
| int fd = -1; | ||
| }; | ||
|
|
||
| static I2C i2cObjs[2]; |
There was a problem hiding this comment.
Probably should make "2" a constant? There's some range checks elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.