Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: up release-please #2305

Merged
merged 1 commit into from
Mar 19, 2025
Merged

chore: up release-please #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,9 @@ jobs:
if: github.event_name == 'push' && github.ref == 'refs/heads/master'
needs: [check, proto, browser, node]
steps:
- uses: google-github-actions/release-please-action@v3
- uses: googleapis/release-please-action@v4
id: release
with:
command: manifest
monorepo-tags: true
token: ${{ secrets.CI_TOKEN }}

- uses: actions/checkout@v3
Expand Down
4 changes: 3 additions & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@
"packages/relay": "0.0.16",
"packages/sdk": "0.0.29",
"packages/discovery": "0.0.6",
"packages/react-native-polyfills": "0.0.1"
"packages/react-native-polyfills": "0.0.1",
"packages/sds": "0.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adklempner adding sds to the release
it's absence was causing failures: release-please wasn't bumping @waku/* packages in it causing issue with proto package https://github.com/waku-org/js-waku/actions/runs/13945155395/job/39030577038?pr=2309

"packages/rln": "0.1.3"
}
2 changes: 1 addition & 1 deletion packages/rln/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@waku/rln",
"version": "0.0.1",
"version": "0.1.3",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danisharora099 fyi rln is getting published too, from where previous repo left

"description": "RLN (Rate Limiting Nullifier) implementation for Waku",
"types": "./dist/index.d.ts",
"module": "./dist/index.js",
Expand Down
5 changes: 4 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"separate-pull-requests": false,
"versioning": "always-bump-patch",
"group-pull-request-title-pattern": "chore: release ${branch}",
"include-component-in-tag": true,
"packages": {
"packages/utils": {},
"packages/proto": {},
Expand All @@ -22,6 +23,8 @@
"packages/sdk": {},
"packages/relay": {},
"packages/discovery": {},
"packages/react-native-polyfills": {}
"packages/react-native-polyfills": {},
"packages/sds": {},
"packages/rln": {}
}
}
Loading