chore: up release-please #2305
Merged
chore: up release-please #2305
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weboko
force-pushed
the
weboko/release-please-4
branch
from
2067ce1 to
aa530be
Compare
size-limit report 📦
|
weboko
force-pushed
the
weboko/release-please-4
branch
from
aa530be to
5cbfd74
Compare
adklempner
approved these changes
Mar 19, 2025
weboko
commented
Mar 19, 2025
| @@ -9,5 +9,7 @@ | |||
| "packages/relay": "0.0.16", | |||
| "packages/sdk": "0.0.29", | |||
| "packages/discovery": "0.0.6", | |||
| "packages/react-native-polyfills": "0.0.1" | |||
| "packages/react-native-polyfills": "0.0.1", | |||
| "packages/sds": "0.0.1", | |||
There was a problem hiding this comment.
@adklempner adding sds to the release
it's absence was causing failures: release-please wasn't bumping @waku/* packages in it causing issue with proto package https://github.com/waku-org/js-waku/actions/runs/13945155395/job/39030577038?pr=2309
weboko
commented
Mar 19, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@waku/rln", | |||
| "version": "0.0.1", | |||
| "version": "0.1.3", | |||
There was a problem hiding this comment.
@danisharora099 fyi rln is getting published too, from where previous repo left
|
honestly, at this point I think a simple script will be better than release-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Description
release-pleasegot updatedsdsandrlnpackages were not added into the release please hence their deps were not bumped leading to issues https://github.com/waku-org/js-waku/actions/runs/13945155395/job/39030577038?pr=2309Solution
Notes