[Connect SDK] Integrate with backend calls for client secret #9287

simond-stripe · 2024-09-16T20:43:53Z

Summary

Adds networking to the example backend (https://stripe-connect-mobile-example-v1.glitch.me/) for getting the publishable key, accounts, and client secret for the SDK.

Motivation

Demonstrates a canonical integration of the ConnectSDK.

Testing

Added tests
Modified tests
Manually verified

Screenshots

UI

demo-1729231634.mp4

Network call logging

github-actions · 2024-09-16T20:44:06Z

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

github-actions · 2024-09-24T18:16:18Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │     7 KiB │     7 KiB │  0 B │   6.8 KiB │   6.8 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ -2 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -2 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20108 │ 20108 │ 0 (+0 -0) 
   types │  6205 │  6205 │ 0 (+0 -0) 
 classes │  4991 │  4991 │ 0 (+0 -0) 
 methods │ 30124 │ 30124 │ 0 (+0 -0) 
  fields │ 17572 │ 17572 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0

APK

   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 28.3 KiB │ -3 B │ 62.6 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 29.5 KiB │ -2 B │ 63.8 KiB │  0 B │ (total)

# Conflicts: # dependencies.gradle # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/networking/EmbeddedComponentService.kt # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/ui/accountonboarding/AccountOnboardingExampleActivity.kt # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/ui/accountonboarding/AccountOnboardingExampleViewModel.kt # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/ui/payouts/PayoutsExampleViewModel.kt

tjclawson-stripe · 2024-10-10T19:37:03Z

dependencies.gradle

@@ -70,6 +70,7 @@ ext.versions = [
        tensorflowLite              : '2.11.0',
        tensorflowLiteSupport       : '0.4.3',
        testParameterInjector       : '1.17',
+        timber                      : '5.0.1',


We have a Logger class in stripe-core. Would this fit your needs?

Yes, this looks great! My goal is to demonstrate reasonable logging behavior in our example app - I've updated the PR to remove Timber.

…egration

lng-stripe

This is coming along nicely!

Approving for now as I know this is in very active development and I don't want to slow momentum. However, I have medium-high FUD around the EmbeddedComponentManager API.

lng-stripe · 2024-10-17T21:48:00Z

...xample/src/main/java/com/stripe/android/connectsdk/example/ui/common/EmbeddedComponentsUi.kt

+
+@Preview(showBackground = true)
+@Composable
+fun LaunchEmbeddedComponentsScreenPreviewWithSelectedAccount() {


Make previews private here and below?

Suggested change

fun LaunchEmbeddedComponentsScreenPreviewWithSelectedAccount() {

private fun LaunchEmbeddedComponentsScreenPreviewWithSelectedAccount() {

lng-stripe · 2024-10-17T21:51:10Z

...ple/src/main/java/com/stripe/android/connectsdk/example/networking/NetworkingInterceptors.kt

+}
+
+object UserAgentHeader : FoldableRequestInterceptor {
+    private fun getUserAgent(): String {


nit: could be a val

lng-stripe · 2024-10-17T21:51:37Z

...e/src/main/java/com/stripe/android/connectsdk/example/networking/EmbeddedComponentService.kt

+    val deserializer = object : Deserializable<T> {
+
+        override fun deserialize(response: Response): T {
+            println(response.toString())


lng-stripe · 2024-10-17T21:56:42Z

...xample/src/main/java/com/stripe/android/connectsdk/example/ui/common/EmbeddedComponentsUi.kt

+fun LaunchEmbeddedComponentsScreen(
+    embeddedComponentName: String,
+    selectedAccount: Merchant?,
+    connectSDKAccounts: List<Merchant>,


optional: Not that performance is a concern, but if it's easy we should enable strong skipping mode to avoid recompositions with list params in composables (plus all the other situations)

Good idea. If I can apply this to just the connect module, I'll do that

lng-stripe · 2024-10-17T21:57:46Z

...xample/src/main/java/com/stripe/android/connectsdk/example/ui/common/EmbeddedComponentsUi.kt

+@OptIn(ExperimentalMaterialApi::class)
+@Composable
+fun AccountSelector(
+    selectedAccount: Merchant? = null,


nit:

Suggested change

selectedAccount: Merchant? = null,

selectedAccount: Merchant?,

lng-stripe · 2024-10-18T14:07:55Z

...android/connectsdk/example/ui/features/accountonboarding/AccountOnboardingExampleActivity.kt

+                        if (sdkPublishableKey != null && accounts != null) {
+                            val embeddedComponentManager = remember(sdkPublishableKey) {
+                                EmbeddedComponentManager(
+                                    activity = this@AccountOnboardingExampleActivity,


Does EmbeddedComponentManager really need to keep an instance of Activity? Can we pass in the activity in present* method calls instead? Currently,

This is a memory leak foot gun for users if they don't properly cleanup the manager when the Activity is destroyed.

There's a disconnect in having both activity and fetchClientSecret as dependencies. In which architectural layer does this class belong? What if we want to cache and share the client secret between managers?

This API prevents users from making this a singleton in their apps, and introduces a lot of friction in setting up DI.

These are great points. This API is changing after review - my follow-up PR will make this a singleton and I believe should resolve most of these concerns, but let me know if you still have FUD after the next PR

lng-stripe · 2024-10-18T15:14:00Z

stripe-connect/src/main/java/com/stripe/android/connectsdk/EmbeddedComponentManager.kt

    constructor(
        @Suppress("UNUSED_PARAMETER") activity: ComponentActivity,
        @Suppress("UNUSED_PARAMETER") configuration: Configuration,
        @Suppress("UNUSED_PARAMETER") fetchClientSecret: FetchClientSecretCallback,
    ) : this() {
-        throw NotImplementedError("Not yet implemented")
+        // TODO MXMOBILE-2760 - replace with actual implementation and remove the @Suppress annotations


We should remove the other throws as well replace them with toasts instead. It was unclear to me as I was testing this when a crash was intentional versus not.

Good call. This should be easy to do while in development.

lng-stripe · 2024-10-18T15:15:23Z

...xample/src/main/java/com/stripe/android/connectsdk/example/ui/common/EmbeddedComponentsUi.kt

+import com.stripe.android.connectsdk.example.networking.Merchant
+
+@Composable
+fun LaunchEmbeddedComponentsScreen(


I thought this was an Effect based on verb-like naming. Should change it to something like:

Suggested change

fun LaunchEmbeddedComponentsScreen(

fun EmbeddedComponentsLauncherScreen(

Good idea. This may change in an upcoming PR due to API revisions anyways, and either way I like the name better!

lng-stripe · 2024-10-18T15:18:27Z

...e/src/main/java/com/stripe/android/connectsdk/example/networking/EmbeddedComponentService.kt

+}
+
+@Serializable
+data class FetchClientSecretResponse(


style: IMO we should prefer having only one public class per file. It makes finding things a lot easier.

Good call. I'll refactor in a follow-up

lng-stripe · 2024-10-18T15:20:22Z

...ndroid/connectsdk/example/ui/features/accountonboarding/AccountOnboardingExampleViewModel.kt

+    val state: StateFlow<PayoutsExampleState> = _state.asStateFlow()
+
+    init {
+        getAccounts()


We'll be adding retrying later?

That's my goal. It's not strictly necessary for this example app, but I think having a strong canonical example is useful

simond-stripe · 2024-10-18T15:56:00Z

@lng thanks for the thorough feedback! This isn't live yet and there's a number of PRs queued up behind this one, so I'll address this PR in a follow-up PR later today.

* Integrate with backend calls for client secret # Conflicts: # dependencies.gradle # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/networking/EmbeddedComponentService.kt # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/ui/accountonboarding/AccountOnboardingExampleActivity.kt # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/ui/accountonboarding/AccountOnboardingExampleViewModel.kt # stripe-connect-example/src/main/java/com/stripe/android/connectsdk/example/ui/payouts/PayoutsExampleViewModel.kt * Fix lint * add dependencies file * Move from timber to Logger * Remove unnecessary import * fix lint for deps * Fix deps * Fix colors, fix merge confligt * Fix icon lint

* Rename stripe-connect -> connect * Rename stripe-connect-example -> connect-example * Update API - fragments, Appearance, and secret callback * Move to stringRes * PR feedback from #9287 * Refactor connectsdk to just connect for package * Remove StrongSkippingMode for now (syntax is wrong) * Update example artifact to connect from connectsdk * Add placeholder Fragment UI * update deps * Remove unneeded function * Remove unneeded import * ... -> … * Remove unneeded Manifest entry * Rename stripe-connect.api to connect.api * Restrict library group * Add API * Update dependency

simond-stripe changed the title ~~Integrate with backend calls for client secret~~ [Connect SDK] Integrate with backend calls for client secret Sep 16, 2024

simond-stripe added the accept-risky-change accept-risky-change label Sep 24, 2024

simond-stripe force-pushed the simond/connect-sdk-example-app branch from 5a99909 to 5d10f7f Compare September 24, 2024 17:58

simond-stripe force-pushed the simond/connect-sdk-example-app-backend-integration branch from 5b9f620 to 132cadd Compare September 24, 2024 18:10

simond-stripe force-pushed the simond/connect-sdk-example-app branch from 601e6a3 to c3eb44d Compare September 24, 2024 18:41

simond-stripe force-pushed the simond/connect-sdk-example-app-backend-integration branch from 132cadd to d6fd4aa Compare September 24, 2024 18:42

simond-stripe force-pushed the simond/connect-sdk-example-app branch from c3eb44d to 57baafe Compare September 24, 2024 19:11

simond-stripe force-pushed the simond/connect-sdk-example-app-backend-integration branch from d6fd4aa to 6c7f034 Compare September 24, 2024 19:11

simond-stripe requested a review from lng-stripe September 26, 2024 04:16

simond-stripe marked this pull request as ready for review September 27, 2024 18:09

simond-stripe requested review from a team as code owners September 27, 2024 18:09

simond-stripe force-pushed the simond/connect-sdk-example-app branch from 57baafe to b024b59 Compare October 1, 2024 17:57

Base automatically changed from simond/connect-sdk-example-app to master October 7, 2024 19:15

simond-stripe force-pushed the simond/connect-sdk-example-app-backend-integration branch from 6c7f034 to 1422da5 Compare October 8, 2024 03:36

simond-stripe added 2 commits October 8, 2024 10:52

Fix lint

1dab786

add dependencies file

3db4ef5

tjclawson-stripe reviewed Oct 10, 2024

View reviewed changes

simond-stripe added 6 commits October 16, 2024 18:11

Move from timber to Logger

9372621

Remove unnecessary import

1ee1c3f

fix lint for deps

c910fb7

Merge branch 'master' into simond/connect-sdk-example-app-backend-int…

7e43b2b

…egration

Merge branch 'master' into simond/connect-sdk-example-app-backend-int…

f674b46

…egration

Fix deps

53911b5

tjclawson-stripe self-requested a review October 17, 2024 17:32

tjclawson-stripe previously approved these changes Oct 17, 2024

View reviewed changes

Fix colors, fix merge confligt

3c2d62b

simond-stripe dismissed tjclawson-stripe’s stale review via 3c2d62b October 18, 2024 06:09

Fix icon lint

b347fb1

simond-stripe requested a review from mludowise-stripe October 18, 2024 13:50

lng-stripe approved these changes Oct 18, 2024

View reviewed changes

simond-stripe merged commit cb70b1c into master Oct 18, 2024
15 checks passed

simond-stripe deleted the simond/connect-sdk-example-app-backend-integration branch October 18, 2024 15:56

simond-stripe added a commit that referenced this pull request Oct 18, 2024

PR feedback from #9287

14dd986

simond-stripe mentioned this pull request Oct 18, 2024

[Connect SDK] Update API based on feedback #9480

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Connect SDK] Integrate with backend calls for client secret #9287

[Connect SDK] Integrate with backend calls for client secret #9287

simond-stripe commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 24, 2024 •

edited

Loading

tjclawson-stripe Oct 10, 2024

simond-stripe Oct 16, 2024

lng-stripe left a comment

lng-stripe Oct 17, 2024

lng-stripe Oct 17, 2024

lng-stripe Oct 17, 2024

lng-stripe Oct 17, 2024

simond-stripe Oct 18, 2024

lng-stripe Oct 17, 2024

lng-stripe Oct 18, 2024

simond-stripe Oct 18, 2024

lng-stripe Oct 18, 2024

simond-stripe Oct 18, 2024

lng-stripe Oct 18, 2024

simond-stripe Oct 18, 2024 •

edited

Loading

lng-stripe Oct 18, 2024

simond-stripe Oct 18, 2024

lng-stripe Oct 18, 2024

simond-stripe Oct 18, 2024

simond-stripe commented Oct 18, 2024

	fun LaunchEmbeddedComponentsScreenPreviewWithSelectedAccount() {
	private fun LaunchEmbeddedComponentsScreenPreviewWithSelectedAccount() {

	selectedAccount: Merchant? = null,
	selectedAccount: Merchant?,

	fun LaunchEmbeddedComponentsScreen(
	fun EmbeddedComponentsLauncherScreen(

[Connect SDK] Integrate with backend calls for client secret #9287

[Connect SDK] Integrate with backend calls for client secret #9287

Conversation

simond-stripe commented Sep 16, 2024 • edited Loading

Summary

Motivation

Testing

Screenshots

UI

Network call logging

github-actions bot commented Sep 16, 2024

github-actions bot commented Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lng-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simond-stripe Oct 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simond-stripe commented Oct 18, 2024

simond-stripe commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

simond-stripe Oct 18, 2024 •

edited

Loading