[Connect SDK] Update API based on feedback #9480

simond-stripe · 2024-10-18T23:06:37Z

Summary

This PR updates the SDK's API based on API review. The review is still in progress so there may be some more changes in the future, but this should be significantly closer to what will be live in production. If you have any more feedback on the API, please let me know!

There are a lot of changes due to refactoring of the package name. I recommend reviewing commit-by-commit.

My next PR will make significant changes to the Example App UI to bring it to parity with the iOS example app. API and general feedback is appreciated, and I recommend holding off on UI-specific feedback until the next PR.

Changes:

Rename the modules to connect and connect-example
Update EmbeddedComponentManager to be a singleton
Components are exposed as Fragments
Incorporate PR feedback from [Connect SDK] Integrate with backend calls for client secret #9287

Motivation

Updating the API based on review

Testing

Added tests
Modified tests
Manually verified

Screenshots

demo-1729293503.mp4

github-actions · 2024-10-21T17:51:12Z

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

github-actions · 2024-10-21T17:58:55Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.8 MiB │   3.8 MiB │  0 B │   8.4 MiB │   8.4 MiB │  0 B 
     arsc │   2.3 MiB │   2.3 MiB │  0 B │   2.3 MiB │   2.3 MiB │  0 B 
 manifest │     5 KiB │     5 KiB │  0 B │  24.7 KiB │  24.7 KiB │  0 B 
      res │ 931.2 KiB │ 931.2 KiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
    other │ 200.9 KiB │ 200.9 KiB │ +5 B │ 442.4 KiB │ 442.4 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ +5 B │  20.3 MiB │  20.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 39655 │ 39655 │ 0 (+0 -0) 
   types │ 13666 │ 13666 │ 0 (+0 -0) 
 classes │ 11364 │ 11364 │ 0 (+0 -0) 
 methods │ 58386 │ 58386 │ 0 (+0 -0) 
  fields │ 38724 │ 38724 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6247 │ 6247 │  0

APK

    compressed    │   uncompressed   │                        
───────────┬──────┼───────────┬──────┤                        
 size      │ diff │ size      │ diff │ path                   
───────────┼──────┼───────────┼──────┼────────────────────────
  53.5 KiB │ +3 B │ 118.7 KiB │  0 B │ ∆ META-INF/CERT.SF     
  50.3 KiB │ +2 B │ 118.6 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
───────────┼──────┼───────────┼──────┼────────────────────────
 103.8 KiB │ +5 B │ 237.3 KiB │  0 B │ (total)

emerge-tools · 2024-10-31T14:31:28Z

3 builds decreased size

Name	Version	Download	Change	Install	Change	Approval
Stripe Identity Example com.stripe.android.identity.example.theme1	20.53.0-theme1 (20)	3.8 MB	⬇️ 2.5 kB (-0.07%)	8.9 MB	⬇️ 5.8 kB (-0.06%)	N/A
Financial Connections Example com.stripe.android.financialconnections.example	20.53.0 (205300)	4.2 MB	⬇️ 346 B	9.4 MB	⬇️ 116 B	N/A
PaymentSheet Example com.stripe.android.paymentsheet.example	20.53.0 (11)	7.1 MB	⬇️ 1.5 MB (-17.35%)	14.4 MB	⬇️ 1.9 MB (-11.38%)	N/A

Stripe Identity Example 20.53.0-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 5.8 kB (-0.06%)
Total download size change: ⬇️ 2.5 kB (-0.07%)

Largest size changes

Item	Install Size Change	Download Size Change
🗑 androidx.compose.ui.node.IntrinsicsPolicy	⬇️ -26.8 kB	⬇️ -12.9 kB
📝 androidx.compose.ui.node.DepthSortedSetsForDifferentPasses	⬆️ 26.2 kB	⬆️ 12.6 kB
🗑 com.stripe.android.camera.framework.AnalyzerLoop$startWorker$2	⬇️ -4.4 kB	⬇️ -2.1 kB
📝 androidx.camera.camera2.internal.MeteringRepeatingSession$1	⬆️ 3.7 kB	⬆️ 1.8 kB
🗑 androidx.constraintlayout.core.PriorityGoalRow$GoalVariableAccess...	⬇️ -3.4 kB	⬇️ -1.7 kB

View Treemap

Financial Connections Example 20.53.0 (205300)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 116 B
Total download size change: ⬇️ 346 B

Largest size changes

Item	Install Size Change	Download Size Change
Other	⬇️ -116 B	⬇️ -346 B

PaymentSheet Example 20.53.0 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 1.9 MB (-11.38%)
Total download size change: ⬇️ 1.5 MB (-17.35%)

Largest size changes

Item	Install Size Change	Download Size Change
🗑 ux_0_5_23_16.tflite	⬇️ -1.4 MB	⬇️ -1.3 MB
🗑 androidx.camera.camera2.internal	⬇️ -149.2 kB	⬇️ -68.1 kB
🗑 androidx.camera.core.impl.utils	⬇️ -126.8 kB	⬇️ -58.0 kB
🗑 androidx.camera.core.AspectRatio	⬇️ -79.7 kB	⬇️ -36.4 kB
📝 com.nimbusds.jose.shaded.asm.DefaultConverter	⬆️ 77.2 kB	⬆️ 35.3 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

simond-stripe · 2024-10-31T16:54:06Z

There are a lot of miscellaneous changes here due to the refactor of the module name from stripe-connect -> connect.

I recommend focusing on this commit in particular: 8167a93. Otherwise, focus on EmbeddedComponentManager, PayoutsFragment, and AccountOnboardingFragment.

The example app is going to change quite a bit in a follow-up PR, so feel free to review but note that I'll likely seek to make changes to the example app in that PR rather than this one (barring any major concerns).

seankenkeremath-stripe · 2024-11-04T16:19:07Z

...e/android/connect/example/ui/features/accountonboarding/AccountOnboardingExampleViewModel.kt

+    }
+
+    // private methods
+
    @OptIn(PrivateBetaConnectSDK::class)


do you still need this if it's private?

seankenkeremath-stripe

Looks good!

amk-stripe · 2024-11-05T21:43:19Z

connect-example/dependencies/dependencies.txt

@@ -305,6 +305,7 @@
 |    |    |    |    +--- androidx.core:core:1.0.0 -> 1.13.0 (*)
 |    |    |    |    \--- androidx.customview:customview:1.0.0 (*)
 |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+|    |    |    +--- androidx.fragment:fragment-compose:1.8.4 (c)


Do you know where this compose version is coming from? We are using older versions in the rest of the SDK (1.6.8 generally and I think 1.7.4 in paymentsheet-example)

This is the Androidx fragment library. It's actually not related to the compose version used in the SDK, and matches the other versions of fragments in use elsewhere: https://developer.android.com/jetpack/androidx/releases/fragment#1.8.4

ah gotcha, thanks for the context!

simond-stripe added 7 commits October 18, 2024 12:29

Rename stripe-connect -> connect

57280d5

Rename stripe-connect-example -> connect-example

6742290

Update API - fragments, Appearance, and secret callback

8167a93

Move to stringRes

50a5783

PR feedback from #9287

14dd986

Refactor connectsdk to just connect for package

d3bac8d

Remove StrongSkippingMode for now (syntax is wrong)

9513923

simond-stripe requested review from a team as code owners October 18, 2024 23:06

simond-stripe added 2 commits October 18, 2024 19:12

Update example artifact to connect from connectsdk

41ac454

Add placeholder Fragment UI

eb45de7

simond-stripe requested review from seankenkeremath-stripe and nschris-stripe October 18, 2024 23:20

Merge branch 'master' into simond/api-update

278e1bc

simond-stripe added the accept-risky-change accept-risky-change label Oct 21, 2024

update deps

d48da14

simond-stripe and others added 9 commits October 22, 2024 07:31

Remove unneeded function

ec9710a

Remove unneeded import

ef0c8de

... -> …

83f94bd

Remove unneeded Manifest entry

9b6301b

Rename stripe-connect.api to connect.api

acc5754

Restrict library group

0b7ff1f

Add API

9619b04

Merge branch 'master' into simond/api-update

bfb7ffd

Update dependency

f6d5889

seankenkeremath-stripe reviewed Nov 4, 2024

View reviewed changes

seankenkeremath-stripe approved these changes Nov 4, 2024

View reviewed changes

simond-stripe requested review from awush-stripe and amk-stripe and removed request for awush-stripe November 5, 2024 19:21

amk-stripe reviewed Nov 5, 2024

View reviewed changes

amk-stripe approved these changes Nov 6, 2024

View reviewed changes

simond-stripe merged commit 3839c7f into master Nov 6, 2024
18 checks passed

simond-stripe deleted the simond/api-update branch November 6, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Connect SDK] Update API based on feedback #9480

[Connect SDK] Update API based on feedback #9480

simond-stripe commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024 •

edited

Loading

emerge-tools bot commented Oct 31, 2024

simond-stripe commented Oct 31, 2024

seankenkeremath-stripe Nov 4, 2024

seankenkeremath-stripe left a comment

amk-stripe Nov 5, 2024

simond-stripe Nov 6, 2024

amk-stripe Nov 6, 2024

[Connect SDK] Update API based on feedback #9480

[Connect SDK] Update API based on feedback #9480

Conversation

simond-stripe commented Oct 18, 2024 • edited Loading

Summary

Motivation

Testing

Screenshots

github-actions bot commented Oct 21, 2024

github-actions bot commented Oct 21, 2024 • edited Loading

emerge-tools bot commented Oct 31, 2024

3 builds decreased size

Stripe Identity Example 20.53.0-theme1 (20)com.stripe.android.identity.example.theme1

Financial Connections Example 20.53.0 (205300)com.stripe.android.financialconnections.example

PaymentSheet Example 20.53.0 (11)com.stripe.android.paymentsheet.example

simond-stripe commented Oct 31, 2024

seankenkeremath-stripe Nov 4, 2024

Choose a reason for hiding this comment

seankenkeremath-stripe left a comment

Choose a reason for hiding this comment

amk-stripe Nov 5, 2024

Choose a reason for hiding this comment

simond-stripe Nov 6, 2024

Choose a reason for hiding this comment

amk-stripe Nov 6, 2024

Choose a reason for hiding this comment

simond-stripe commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

Stripe Identity Example 20.53.0-theme1 (20)
com.stripe.android.identity.example.theme1

Financial Connections Example 20.53.0 (205300)
com.stripe.android.financialconnections.example

PaymentSheet Example 20.53.0 (11)
com.stripe.android.paymentsheet.example