proper typing of types

closes #1
stephanstapel · May 26, 2024 · 043a695 · 043a695
1 parent 1ae651d
commit 043a695
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/BrickOwlSharp.Client/Inventory.cs b/BrickOwlSharp.Client/Inventory.cs
@@ -87,8 +87,8 @@ public class Inventory
         [JsonPropertyName("reserve_uid"), JsonConverter(typeof(IntStringConverter))]
         public int? ReserveUid { get; set; }
 
-        [JsonPropertyName("type")]
-        public string Type{ get; set; }
+        [JsonPropertyName("type"), JsonConverter(typeof(ItemTypeStringConverter))]
+        public ItemType Type { get; set; }
 
         [JsonPropertyName("tier_price"), JsonConverter(typeof(TierPriceListConverter))]
         public List<TierPrice> TierPrices { get; set; }

diff --git a/BrickOwlSharp.Client/OrderItem.cs b/BrickOwlSharp.Client/OrderItem.cs
@@ -39,8 +39,8 @@ public class OrderItem
         [JsonPropertyName("name")]
         public string Name { get; set; }
 
-        [JsonPropertyName("type")]
-        public string Type { get; set; }
+        [JsonPropertyName("type"), JsonConverter(typeof(ItemTypeStringConverter))]
+        public ItemType Type { get; set; }
 
         [JsonPropertyName("color_name")]
         public string Color_Name { get; set; }

diff --git a/BrickOwlSharp.Demos/BrickOwlSharp.Demos.csproj b/BrickOwlSharp.Demos/BrickOwlSharp.Demos.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

diff --git a/BrickOwlSharp.Demos/InventoryDemo.cs b/BrickOwlSharp.Demos/InventoryDemo.cs
@@ -44,21 +44,19 @@ internal async Task RunAsync()
                 Quantity = 1,
                 Price = 1000.15m // make sure nobody will ever buy it :)
             });
-
-            /*
+
             bool updateResult = await client.UpdateInventoryAsync(new UpdateInventory()
             {
-                LotId = 107931517,
+                LotId = newInventoryResult.LotId.Value,
                 AbsoluteQuantity = 23                
             });            
-            */
 
             foreach (Inventory inventory in await client.GetInventoryAsync())
             {
-                Console.WriteLine($"{inventory.Id}: quantity {inventory.Quantity}, lot id: {inventory.LotId}");
+                Console.WriteLine($"{inventory.Id}: quantity {inventory.Quantity}, lot id: {inventory.LotId}, type: {inventory.Type}");
             }
 
-            bool result = await client.DeleteInventoryAsync(new DeleteInventory() { LotId = 107931627 });
+            bool result = await client.DeleteInventoryAsync(new DeleteInventory() { LotId = newInventoryResult.LotId.Value });
         }
     }
 }