Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 moved logic into algorithm.csv #190

Open
wants to merge 4 commits into
base: docs/design-into-algorithm-and-pseudocode
Choose a base branch
from

Conversation

lwjohnst86
Copy link
Member

Description

These changes finish moving the algorithm logic into the algorithm.csv file. Plus did some small tidying up of the algorithm file.

Checklist

  • Ran just run-all

Copy link
Contributor

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Just have some minor suggestions - like, I don't think the quotes ("") are intentional (but I could be wrong).

data-raw/algorithm.csv Show resolved Hide resolved
data-raw/algorithm.csv Outdated Show resolved Hide resolved
data-raw/algorithm.csv Outdated Show resolved Hide resolved
data-raw/algorithm.csv Show resolved Hide resolved
vignettes/algorithm.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for clarifying :)

data-raw/algorithm.csv Outdated Show resolved Hide resolved
data-raw/algorithm.csv Outdated Show resolved Hide resolved
@lwjohnst86 lwjohnst86 requested a review from signekb February 10, 2025 12:30
Copy link
Contributor

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 👍 Great 👍 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants